From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johan Hovold Subject: Re: [PATCH 4/7] driver core: fix automatic pinctrl management Date: Wed, 31 May 2017 10:35:23 +0200 Message-ID: <20170531083523.GD6735@localhost> References: <20170530162554.26159-1-johan@kernel.org> <20170530162554.26159-5-johan@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Linus Walleij Cc: Johan Hovold , Greg Kroah-Hartman , Peter Chen , Rob Herring , Arnd Bergmann , Sricharan R , Zhang Rui , Eduardo Valentin , "linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-pm@vger.kernel.org On Wed, May 31, 2017 at 02:39:28AM +0200, Linus Walleij wrote: > On Tue, May 30, 2017 at 6:25 PM, Johan Hovold wrote: > > > Commit ab78029ecc34 ("drivers/pinctrl: grab default handles from device > > core") added automatic pin-control management to driver core by looking > > up and setting any default pinctrl state found in device tree while a > > device is being probed. > > Actually we do not just support device tree, but also passing pin control > states from board files. It is handled by the core all the same. > So it's not a device tree thing. > > One of those days we will have ACPI passing state tables too... > > But I understand what you mean. Yes, I could have mentioned board files, but this problem only applies to device-tree descriptions (for the time being at least). > > Fix this by checking the new of_node_reused flag and skipping automatic > > pinctrl configuration during probe if set. > > Seems like a solid idea. I hope we don't need another quirk for ACPI. We should be able to just generalise and rename the flag (or add a second one) if it turns out ACPI needs this too. > Acked-by: Linus Walleij Thanks, Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html