From: Johan Hovold <johan@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Peter Chen <peter.chen@nxp.com>, Rob Herring <robh@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Sricharan R <sricharan@codeaurora.org>,
Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-usb@vger.kernel.org, Johan Hovold <johan@kernel.org>,
Laxman Dewangan <ldewangan@nvidia.com>
Subject: [PATCH v2 7/7] thermal: max77620: fix pinmux conflict on reprobe
Date: Tue, 6 Jun 2017 17:59:04 +0200 [thread overview]
Message-ID: <20170606155904.26819-8-johan@kernel.org> (raw)
In-Reply-To: <20170606155904.26819-1-johan@kernel.org>
Use the new helper for reusing a device-tree node of another device
instead of managing the node references explicitly.
This also makes sure that the new of_node_reuse flag is set if the
device is ever reprobed, something which specifically now avoids driver
core from attempting to claim any pinmux resources already claimed by
the parent device.
Fixes: ec4664b3fd6d ("thermal: max77620: Add thermal driver for reporting junction temp")
Cc: Laxman Dewangan <ldewangan@nvidia.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/thermal/max77620_thermal.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/thermal/max77620_thermal.c b/drivers/thermal/max77620_thermal.c
index 71d35f3c9215..159bbcee8821 100644
--- a/drivers/thermal/max77620_thermal.c
+++ b/drivers/thermal/max77620_thermal.c
@@ -112,12 +112,10 @@ static int max77620_thermal_probe(struct platform_device *pdev)
}
/*
- * Drop any current reference to a device-tree node and get a
- * reference to the parent's node which will be balanced on reprobe or
- * on platform-device release.
+ * The reference taken to the parent's node which will be balanced on
+ * reprobe or on platform-device release.
*/
- of_node_put(pdev->dev.of_node);
- pdev->dev.of_node = of_node_get(pdev->dev.parent->of_node);
+ device_set_of_node_from_dev(&pdev->dev, pdev->dev.parent);
mtherm->tz_device = devm_thermal_zone_of_sensor_register(&pdev->dev, 0,
mtherm, &max77620_thermal_ops);
--
2.13.0
prev parent reply other threads:[~2017-06-06 15:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 15:58 [PATCH v2 0/7] driver core/USB/thermal: fix device-tree node reuse Johan Hovold
2017-06-06 15:58 ` [PATCH v2 1/7] USB: core: fix device node leak Johan Hovold
2017-06-06 15:58 ` [PATCH v2 2/7] USB: of: document reference taken by child-lookup helper Johan Hovold
2017-06-06 15:59 ` [PATCH v2 3/7] driver core: add helper to reuse a device-tree node Johan Hovold
2017-06-06 15:59 ` [PATCH v2 4/7] driver core: fix automatic pinctrl management Johan Hovold
[not found] ` <20170606155904.26819-1-johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-06-06 15:59 ` [PATCH v2 5/7] USB: of: fix root-hub device-tree node handling Johan Hovold
2017-06-06 15:59 ` [PATCH v2 6/7] thermal: max77620: fix device-node reference imbalance Johan Hovold
2017-06-06 15:59 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170606155904.26819-8-johan@kernel.org \
--to=johan@kernel.org \
--cc=arnd@arndb.de \
--cc=edubezval@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ldewangan@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@nxp.com \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
--cc=sricharan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).