From: Sebastian Reichel <sre@kernel.org>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Wei Yongjun <weiyongjun1@huawei.com>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH -next] power: supply: ltc3651-charger: Fix wrong pointer passed to PTR_ERR()
Date: Wed, 7 Jun 2017 22:16:21 +0200 [thread overview]
Message-ID: <20170607201621.bmovt25hqo2s7udu@earth> (raw)
In-Reply-To: <20170517121132.7052-1-weiyj.lk@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 361 bytes --]
Hi,
On Wed, May 17, 2017 at 12:11:32PM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> PTR_ERR should access the value just tested by IS_ERR, otherwise
> the wrong error code will be returned.
I queued the same patch from Dan, which had the better description
incl. a Fixes, but added your Signed-off-by.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-06-07 20:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 12:11 [PATCH -next] power: supply: ltc3651-charger: Fix wrong pointer passed to PTR_ERR() Wei Yongjun
2017-05-19 0:59 ` Dmitry Torokhov
2017-05-19 1:27 ` weiyongjun (A)
2017-05-19 22:07 ` Dmitry Torokhov
2017-06-07 20:16 ` Sebastian Reichel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170607201621.bmovt25hqo2s7udu@earth \
--to=sre@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-pm@vger.kernel.org \
--cc=weiyj.lk@gmail.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).