Linux Power Management development
 help / color / mirror / Atom feed
From: Ladislav Michl <ladis@linux-mips.org>
To: Mike Looijmans <mike.looijmans@topic.nl>
Cc: linux-pm@vger.kernel.org,
	Javier Martinez Canillas <javier@osg.samsung.com>
Subject: Re: [PATCH 2/2] power: supply: ltc2941-battery-gauge: Add support for LTC2942
Date: Mon, 12 Jun 2017 20:07:41 +0200	[thread overview]
Message-ID: <20170612180741.indbu2qkt6hz7ji4@lenoch> (raw)
In-Reply-To: <c854309e-68b0-c1f2-a7f8-3161e38e1579@topic.nl>

On Mon, Jun 12, 2017 at 06:29:54PM +0200, Mike Looijmans wrote:
> On 12-6-2017 17:04, Ladislav Michl wrote:
> > LTC2942 is pin compatible with LTC2941 providing additional
> > informations about battery voltage and temperature. It can
> > be runtime detected using bit A7 in the Status register.
> 
> Runtime detection is always nice. I'd suggest adding "ltc2942" to the device
> name list, since having to specify "ltc2941" when the chip is in fact an
> "ltc2942" looks a bit strange.

It is not that strange after the one who would otherwise blindly type ltc2942
reads the datasheet ;-)

> Again, no strong preference, whatever the maintainers think is best is fine
> with me also.

What about adding something like this?

diff --git a/Documentation/devicetree/bindings/power/supply/ltc2941.txt b/Documentation/devicetree/bindings/power/supply/ltc2941.txt
index a9d7aa60558b..0d065d54d294 100644
--- a/Documentation/devicetree/bindings/power/supply/ltc2941.txt
+++ b/Documentation/devicetree/bindings/power/supply/ltc2941.txt
@@ -1,9 +1,10 @@
-binding for LTC2941 and LTC2943 battery gauges
+binding for LTC2941, LTC2942 and LTC2943 battery gauges
 
-Both the LTC2941 and LTC2943 measure battery capacity.
-The LTC2943 is compatible with the LTC2941, it adds voltage and
-temperature monitoring, and uses a slightly different conversion
-formula for the charge counter.
+All chips measure battery capacity.
+The LTC2942 is pin compatible with the LTC2941, it adds voltage and
+temperature monitoring, and is runtime detected. LTC2943 is software
+compatible, uses a slightly different conversion formula for the
+charge counter and adds voltage, current and temperature monitoring.
 
 Required properties:
 - compatible: Should contain "lltc,ltc2941" or "lltc,ltc2943" which also

  reply	other threads:[~2017-06-12 18:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-12 15:02 [PATCH 0/2] power: supply: ltc2941-battery-gauge: Support LTC2942 Ladislav Michl
2017-06-12 15:03 ` [PATCH 1/2] power: supply: ltc2941-battery-gauge: Define LTC2942 registers Ladislav Michl
2017-06-12 16:26   ` Mike Looijmans
2017-06-12 17:59     ` Ladislav Michl
2017-06-12 15:04 ` [PATCH 2/2] power: supply: ltc2941-battery-gauge: Add support for LTC2942 Ladislav Michl
2017-06-12 16:29   ` Mike Looijmans
2017-06-12 18:07     ` Ladislav Michl [this message]
2017-06-14  0:08     ` Ladislav Michl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170612180741.indbu2qkt6hz7ji4@lenoch \
    --to=ladis@linux-mips.org \
    --cc=javier@osg.samsung.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=mike.looijmans@topic.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox