From: Viresh Kumar <viresh.kumar@linaro.org>
To: Colin King <colin.king@canonical.com>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
linux-pm@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq: sfi: make freq_table static
Date: Thu, 15 Jun 2017 15:28:43 +0530 [thread overview]
Message-ID: <20170615095843.GA3942@vireshk-i7> (raw)
In-Reply-To: <20170615095559.21973-1-colin.king@canonical.com>
On 15-06-17, 10:55, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> pointer freq_table can be made static as it does not need to be in
> global scope.
>
> Cleans up sparse warning:
> "symbol 'freq_table' was not declared. Should it be static?"
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/cpufreq/sfi-cpufreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/sfi-cpufreq.c b/drivers/cpufreq/sfi-cpufreq.c
> index 992ce6f9abec..3779742f86e3 100644
> --- a/drivers/cpufreq/sfi-cpufreq.c
> +++ b/drivers/cpufreq/sfi-cpufreq.c
> @@ -24,7 +24,7 @@
>
> #include <asm/msr.h>
>
> -struct cpufreq_frequency_table *freq_table;
> +static struct cpufreq_frequency_table *freq_table;
> static struct sfi_freq_table_entry *sfi_cpufreq_array;
> static int num_freq_table_entries;
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
prev parent reply other threads:[~2017-06-15 9:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-15 9:55 [PATCH] cpufreq: sfi: make freq_table static Colin King
2017-06-15 9:58 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170615095843.GA3942@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).