From: Brian Norris <briannorris@chromium.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Heiko Stuebner <heiko@sntech.de>,
Linus Walleij <linus.walleij@linaro.org>,
linux-rockchip@lists.infradead.org,
Julia Cartwright <julia@ni.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-gpio@vger.kernel.org, John Keeping <john@metanate.com>,
linux-pm@vger.kernel.org, Doug Anderson <dianders@chromium.org>,
Peter Zijlstra <peterz@infradead.org>,
Tony Lindgren <tony@atomide.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH v2] PM / wakeirq: Convert to SRCU
Date: Mon, 26 Jun 2017 13:37:11 -0700 [thread overview]
Message-ID: <20170626203709.GA11099@google.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1706251930220.2528@nanos>
On Sun, Jun 25, 2017 at 07:31:13PM +0200, Thomas Gleixner wrote:
> The wakeirq infrastructure uses RCU to protect the list of wakeirqs. That
> breaks the irq bus locking infrastructure, which is allows sleeping
> functions to be called so interrupt controllers behind slow busses,
> e.g. i2c, can be handled.
>
> The wakeirq functions hold rcu_read_lock and call into irq functions, which
> in case of interrupts using the irq bus locking will trigger a
> might_sleep() splat.
>
> Convert the wakeirq infrastructure to Sleepable RCU and unbreak it.
>
> Fixes: 4990d4fe327b ("PM / Wakeirq: Add automated device wake IRQ handling")
> Reported-by: Brian Norris <briannorris@chromium.org>
> Suggested-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
> drivers/base/power/wakeup.c | 32 ++++++++++++++++++--------------
> 1 file changed, 18 insertions(+), 14 deletions(-)
This resolves the warnings I've seen, for sure. And I don't seem to have
any new suspend/resume problems, so:
Tested-by: Brian Norris <briannorris@chromium.org>
next prev parent reply other threads:[~2017-06-26 20:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-24 9:56 PM / wakeirq: Convert to SRCU Thomas Gleixner
2017-06-24 12:02 ` Rafael J. Wysocki
2017-06-24 12:13 ` Thomas Gleixner
2017-06-24 12:30 ` Rafael J. Wysocki
2017-06-24 13:53 ` Paul E. McKenney
2017-06-25 9:11 ` Thomas Gleixner
2017-06-25 14:45 ` Paul E. McKenney
2017-06-25 17:31 ` [PATCH v2] " Thomas Gleixner
2017-06-25 18:29 ` Paul E. McKenney
2017-06-26 10:15 ` Tony Lindgren
2017-06-26 20:37 ` Brian Norris [this message]
2017-06-28 20:54 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170626203709.GA11099@google.com \
--to=briannorris@chromium.org \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=john@metanate.com \
--cc=julia@ni.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).