Re: [PATCH v3 2/2] power: supply: ltc2941-battery-gauge: Add support for LTC2942

[Sebastian Reichel <sebastian.reichel@collabora.co.uk>]

[-- Attachment #1: Type: text/plain, Size: 2266 bytes --]

Hi,

Next mail should CC DT binding people.

On Sat, Jun 24, 2017 at 05:09:02PM +0200, Ladislav Michl wrote:
> LTC2942 is pin compatible with LTC2941 providing additional
> informations about battery voltage and temperature. It can
> be runtime detected using bit A7 in the Status register.
> 
> Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
> ---
>  Changes:
>  - v2: reworked voltage computing to not overflow and keep presision
>  - v3: update devicetree binding documentation
> 
>  .../devicetree/bindings/power/supply/ltc2941.txt   | 11 ++--
>  drivers/power/supply/ltc2941-battery-gauge.c       | 76 +++++++++++++++++-----
>  2 files changed, 64 insertions(+), 23 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/ltc2941.txt b/Documentation/devicetree/bindings/power/supply/ltc2941.txt
> index a9d7aa60558b..0d065d54d294 100644
> --- a/Documentation/devicetree/bindings/power/supply/ltc2941.txt
> +++ b/Documentation/devicetree/bindings/power/supply/ltc2941.txt
> @@ -1,9 +1,10 @@
> -binding for LTC2941 and LTC2943 battery gauges
> +binding for LTC2941, LTC2942 and LTC2943 battery gauges
>  
> -Both the LTC2941 and LTC2943 measure battery capacity.
> -The LTC2943 is compatible with the LTC2941, it adds voltage and
> -temperature monitoring, and uses a slightly different conversion
> -formula for the charge counter.
> +All chips measure battery capacity.
> +The LTC2942 is pin compatible with the LTC2941, it adds voltage and
> +temperature monitoring, and is runtime detected. LTC2943 is software
> +compatible, uses a slightly different conversion formula for the
> +charge counter and adds voltage, current and temperature monitoring.
>  
>  Required properties:
>  - compatible: Should contain "lltc,ltc2941" or "lltc,ltc2943" which also

ltc2942 should get its own compatible value.

> diff --git a/drivers/power/supply/ltc2941-battery-gauge.c b/drivers/power/supply/ltc2941-battery-gauge.c
> index 0a1b69bbca7f..c4a949dddb66 100644
> --- a/drivers/power/supply/ltc2941-battery-gauge.c
> +++ b/drivers/power/supply/ltc2941-battery-gauge.c
> [...]

In addition to the binding document the new compatible value also
needs to be added in the driver.

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]