From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liam Breck Subject: [RFC v1 5/6] power: supply: bq27xxx: Flag identical chip data when in debug mode Date: Sat, 8 Jul 2017 19:16:59 -0700 Message-ID: <20170709021700.14354-6-liam@networkimprov.net> References: <20170709021700.14354-1-liam@networkimprov.net> Return-path: Received: from mail-pf0-f195.google.com ([209.85.192.195]:36277 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751654AbdGICRn (ORCPT ); Sat, 8 Jul 2017 22:17:43 -0400 Received: by mail-pf0-f195.google.com with SMTP id z6so9736878pfk.3 for ; Sat, 08 Jul 2017 19:17:42 -0700 (PDT) In-Reply-To: <20170709021700.14354-1-liam@networkimprov.net> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Sebastian Reichel , =?UTF-8?q?Pali=20Roh=C3=A1r?= , linux-pm@vger.kernel.org Cc: Paul Kocialkowski , Liam Breck From: Liam Breck The driver has 13 unique register maps, several of which are shared by multiple chips. When adding support for a new chip, it's easy to add a duplicate map by mistake. In debug mode we now scan bq27xxx_chip_data[n].regs/props/dm_regs for duplicates. Signed-off-by: Liam Breck --- drivers/power/supply/bq27xxx_battery.c | 36 +++++++++++++++++++++++++++++++++- 1 file changed, 35 insertions(+), 1 deletion(-) diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c index 5d3893a9..54755c88 100644 --- a/drivers/power/supply/bq27xxx_battery.c +++ b/drivers/power/supply/bq27xxx_battery.c @@ -883,7 +883,7 @@ static struct bq27xxx_dm_reg bq27621_dm_regs[] = { .props = bq27##ref##_props, \ .props_size = ARRAY_SIZE(bq27##ref##_props) } -static struct { +static struct bq27xxx_chip_datum { u32 opts; int acts_like; //todo drop this when opts fully implemented u32 unseal_key; @@ -918,6 +918,38 @@ static struct { [BQ27621] = BQ27XXX_DATA(621, BQ27421, 0x80008000, BQ27XXX_O_CFGUP | BQ27XXX_O_RAM), }; +static void __maybe_unused bq27xxx_battery_dbg_dupes(struct bq27xxx_device_info *di) +{ + const size_t max = ARRAY_SIZE(bq27xxx_chip_data); + const char * const msg = "bq27xxx_chip_data[%d].%s & [%d].%s are identical\n"; + struct bq27xxx_chip_datum *a, *b; + int i, j; + + for (i = 1; i < max-1; i++) { + a = bq27xxx_chip_data + i; + + for (j = i+1; j < max; j++) { + b = bq27xxx_chip_data + j; + + if (a->regs != b->regs && + !memcmp(a->regs, b->regs, sizeof(bq27000_regs))) + dev_warn(di->dev, msg, i, "regs", j, "regs"); + + if (a->props != b->props && + a->props_size == b->props_size && + !memcmp(a->props, b->props, a->props_size)) + dev_warn(di->dev, msg, i, "props", j, "props"); + + if (a->dm_regs != b->dm_regs && + !memcmp(a->dm_regs, b->dm_regs, sizeof(bq27500_dm_regs))) + dev_warn(di->dev, msg, i, "dm_regs", j, "dm_regs"); + } + } +} +#ifndef DEBUG +#define bq27xxx_battery_dbg_dupes(di) +#endif + static DEFINE_MUTEX(bq27xxx_list_lock); static LIST_HEAD(bq27xxx_battery_devices); @@ -1989,6 +2021,8 @@ int bq27xxx_battery_setup(struct bq27xxx_device_info *di) .drv_data = di, }; + bq27xxx_battery_dbg_dupes(di); + INIT_DELAYED_WORK(&di->work, bq27xxx_battery_poll); mutex_init(&di->lock); -- 2.13.1