From: "Pali Rohár" <pali.rohar@gmail.com>
To: Liam Breck <liam@networkimprov.net>
Cc: Sebastian Reichel <sre@kernel.org>,
linux-pm@vger.kernel.org, Paul Kocialkowski <contact@paulk.fr>,
Liam Breck <kernel@networkimprov.net>
Subject: Re: [RFC v1 3/6] power: supply: bq27xxx: Enable data memory update for certain chips
Date: Sun, 9 Jul 2017 11:07:44 +0200 [thread overview]
Message-ID: <201707091107.44653@pali> (raw)
In-Reply-To: <20170709021700.14354-4-liam@networkimprov.net>
[-- Attachment #1: Type: Text/Plain, Size: 516 bytes --]
On Sunday 09 July 2017 04:16:57 Liam Breck wrote:
> From: Liam Breck <kernel@networkimprov.net>
>
> Support data memory update on BQ27500, 545, 425, 421, 441, 621.
> With exception of BQ27425, these are only enabled #ifdef DEBUG,
> as they are not tested.
>
> Signed-off-by: Liam Breck <kernel@networkimprov.net>
> ---
> drivers/power/supply/bq27xxx_battery.c | 164
Why under #ifdef DEBUG? Seems that this is misusing DEBUG which is used
for other things.
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2017-07-09 9:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-09 2:16 [RFC v1 0/6] bq27xxx_battery data memory update Liam Breck
2017-07-09 2:16 ` [RFC v1 1/6] power: supply: bq27xxx: Create single chip data table Liam Breck
2017-07-25 11:21 ` Sebastian Reichel
2017-07-09 2:16 ` [RFC v1 2/6] power: supply: bq27xxx: Add chip IDs for previously shadowed chips Liam Breck
2017-07-25 12:52 ` Sebastian Reichel
2017-07-09 2:16 ` [RFC v1 3/6] power: supply: bq27xxx: Enable data memory update for certain chips Liam Breck
2017-07-09 9:07 ` Pali Rohár [this message]
2017-07-09 14:13 ` Liam Breck
2017-07-09 15:12 ` Pali Rohár
2017-07-25 11:17 ` Sebastian Reichel
2017-07-09 2:16 ` [RFC v1 4/6] power: supply: bq27xxx: Add chip data options for cfgupdate & ram-only Liam Breck
2017-07-25 11:24 ` Sebastian Reichel
2017-07-09 2:16 ` [RFC v1 5/6] power: supply: bq27xxx: Flag identical chip data when in debug mode Liam Breck
2017-07-25 13:04 ` Sebastian Reichel
2017-07-09 2:17 ` [RFC v1 6/6] power: supply: bq27xxx: Remove duplicate chip data arrays Liam Breck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201707091107.44653@pali \
--to=pali.rohar@gmail.com \
--cc=contact@paulk.fr \
--cc=kernel@networkimprov.net \
--cc=liam@networkimprov.net \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).