* [PATCH] PM / OPP: OF: Use pr_debug() instead of pr_err() while adding OPP table
@ 2017-07-12 3:51 Viresh Kumar
2017-07-13 6:10 ` Stephen Boyd
0 siblings, 1 reply; 3+ messages in thread
From: Viresh Kumar @ 2017-07-12 3:51 UTC (permalink / raw)
To: Rafael Wysocki, Viresh Kumar, Nishanth Menon, Stephen Boyd
Cc: Viresh Kumar, linux-pm, Vincent Guittot, Mason, linux-kernel
Some platforms add the OPPs dynamically from platform specific drivers
instead of getting them statically from DT. The cpufreq-dt driver
already ignores the return value of dev_pm_opp_of_cpumask_add_table() to
not error out for such cases, but we still end up printing error message
from that routine. That's not nice.
Convert the print message to use pr_debug() instead.
Reported-by: Mason <slash.tmp@free.fr>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/base/power/opp/of.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/base/power/opp/of.c b/drivers/base/power/opp/of.c
index 779428676f63..f1d8b01db546 100644
--- a/drivers/base/power/opp/of.c
+++ b/drivers/base/power/opp/of.c
@@ -533,8 +533,12 @@ int dev_pm_opp_of_cpumask_add_table(const struct cpumask *cpumask)
ret = dev_pm_opp_of_add_table(cpu_dev);
if (ret) {
- pr_err("%s: couldn't find opp table for cpu:%d, %d\n",
- __func__, cpu, ret);
+ /*
+ * OPP may get registered dynamically, don't print error
+ * message here.
+ */
+ pr_debug("%s: couldn't find opp table for cpu:%d, %d\n",
+ __func__, cpu, ret);
/* Free all other OPPs */
dev_pm_opp_of_cpumask_remove_table(cpumask);
--
2.13.0.71.gd7076ec9c9cb
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] PM / OPP: OF: Use pr_debug() instead of pr_err() while adding OPP table
2017-07-12 3:51 [PATCH] PM / OPP: OF: Use pr_debug() instead of pr_err() while adding OPP table Viresh Kumar
@ 2017-07-13 6:10 ` Stephen Boyd
2017-07-21 22:40 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Boyd @ 2017-07-13 6:10 UTC (permalink / raw)
To: Viresh Kumar
Cc: Rafael Wysocki, Viresh Kumar, Nishanth Menon, linux-pm,
Vincent Guittot, Mason, linux-kernel
On 07/12, Viresh Kumar wrote:
> Some platforms add the OPPs dynamically from platform specific drivers
> instead of getting them statically from DT. The cpufreq-dt driver
> already ignores the return value of dev_pm_opp_of_cpumask_add_table() to
> not error out for such cases, but we still end up printing error message
> from that routine. That's not nice.
>
> Convert the print message to use pr_debug() instead.
>
> Reported-by: Mason <slash.tmp@free.fr>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PM / OPP: OF: Use pr_debug() instead of pr_err() while adding OPP table
2017-07-13 6:10 ` Stephen Boyd
@ 2017-07-21 22:40 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2017-07-21 22:40 UTC (permalink / raw)
To: Stephen Boyd, Viresh Kumar
Cc: Viresh Kumar, Nishanth Menon, linux-pm, Vincent Guittot, Mason,
linux-kernel
On Wednesday, July 12, 2017 11:10:14 PM Stephen Boyd wrote:
> On 07/12, Viresh Kumar wrote:
> > Some platforms add the OPPs dynamically from platform specific drivers
> > instead of getting them statically from DT. The cpufreq-dt driver
> > already ignores the return value of dev_pm_opp_of_cpumask_add_table() to
> > not error out for such cases, but we still end up printing error message
> > from that routine. That's not nice.
> >
> > Convert the print message to use pr_debug() instead.
> >
> > Reported-by: Mason <slash.tmp@free.fr>
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > ---
>
> Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-21 22:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-12 3:51 [PATCH] PM / OPP: OF: Use pr_debug() instead of pr_err() while adding OPP table Viresh Kumar
2017-07-13 6:10 ` Stephen Boyd
2017-07-21 22:40 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).