Re: [PATCH] PM / OPP: Don't check not plugged in CPUs to avoid error

[Viresh Kumar <viresh.kumar@linaro.org>]

On 19-07-17, 16:10, Waldemar Rymarkiewicz wrote:
> Anyway, below a proposal how we can solve the problem of getting
> shared CPUs when hotplug is used.
> 
> 
> @@ -555,8 +576,7 @@ EXPORT_SYMBOL_GPL(dev_pm_opp_of_cpumask_add_table);
>  int dev_pm_opp_of_get_sharing_cpus(struct device *cpu_dev,
>                                    struct cpumask *cpumask)
>  {
> -       struct device_node *np, *tmp_np;
> -       struct device *tcpu_dev;
> +       struct device_node *np, *tmp_np, *cpu_np;
>         int cpu, ret = 0;
> 
>         /* Get OPP descriptor node */
> @@ -572,22 +592,16 @@ int dev_pm_opp_of_get_sharing_cpus(struct device *cpu_dev,
>         if (!of_property_read_bool(np, "opp-shared"))
>                 goto put_cpu_node;
> 
> -       for_each_possible_cpu(cpu) {
> +       for_each_node_by_type(cpu_np, "cpu") {
> +               cpu = of_device_node_get_cpu(cpu_np);

Actually you can keep the original loop as it is and use
of_get_cpu_node() here. We better open code of_device_node_get_cpu()
here.

> +
>                 if (cpu == cpu_dev->id)
>                         continue;
> 
> -               tcpu_dev = get_cpu_device(cpu);
> -               if (!tcpu_dev) {
> -                       dev_err(cpu_dev, "%s: failed to get cpu%d device\n",
> -                               __func__, cpu);
> -                       ret = -ENODEV;
> -                       goto put_cpu_node;
> -               }
> -
>                 /* Get OPP descriptor node */
> -               tmp_np = _of_get_opp_desc_node(tcpu_dev);

I see dev_pm_opp_of_get_opp_desc_node() here, not sure how you got
above change..

> +               tmp_np = of_parse_phandle(cpu_np, "operating-points-v2", 0);

I would create _opp_of_get_opp_desc_node(np) and use it everywhere,
i.e. from dev_pm_opp_of_get_opp_desc_node() as well.

>                 if (!tmp_np) {
> -                       dev_err(tcpu_dev, "%s: Couldn't find tcpu_dev node.\n",
> +                       dev_err(cpu_dev, "%s: Couldn't find tcpu_dev node.\n",
>                                 __func__);
>                         ret = -ENOENT;
>                         goto put_cpu_node;

Thanks.

-- 
viresh