[PATCH 0/2] ARM: add missing includes to header files

[PATCH 0/2] ARM: add missing includes to header files

[Johan Hovold]

Add two missing include directives to two header files to avoid
compile breakage when the required symbols have not already been
defined.

The missing SCU include broke compilation of the (not-yet-merged)
suspend support for am335x when !CONFIG_HAVE_ARM_SCU for example:

	https://lkml.kernel.org/r/20170704131441.GH27842@localhost

Johan


Johan Hovold (2):
  ARM: scu: add missing errno include
  ARM: pm: add missing types include

 arch/arm/include/asm/smp_scu.h | 1 +
 arch/arm/include/asm/suspend.h | 2 ++
 2 files changed, 3 insertions(+)

-- 
2.13.2

[PATCH 1/2] ARM: scu: add missing errno include

[Johan Hovold]

Add missing errno include to make the header self-contained and avoid
compilation breakage when compiling shared code without
CONFIG_HAVE_ARM_SCU.

Signed-off-by: Johan Hovold <johan@kernel.org>
---
 arch/arm/include/asm/smp_scu.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/include/asm/smp_scu.h b/arch/arm/include/asm/smp_scu.h
index bfe163c40024..5983f6bc62d5 100644
--- a/arch/arm/include/asm/smp_scu.h
+++ b/arch/arm/include/asm/smp_scu.h
@@ -7,6 +7,7 @@
 
 #ifndef __ASSEMBLER__
 
+#include <linux/errno.h>
 #include <asm/cputype.h>
 
 static inline bool scu_a9_has_base(void)
-- 
2.13.2

[PATCH 2/2] ARM: pm: add missing types include

[Johan Hovold]

Add missing types.h include to make the suspend header self-contained
and avoid compilation breakage due to include-directive ordering.

Signed-off-by: Johan Hovold <johan@kernel.org>
---
 arch/arm/include/asm/suspend.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/include/asm/suspend.h b/arch/arm/include/asm/suspend.h
index 6c7182f32cef..a61905c86732 100644
--- a/arch/arm/include/asm/suspend.h
+++ b/arch/arm/include/asm/suspend.h
@@ -1,6 +1,8 @@
 #ifndef __ASM_ARM_SUSPEND_H
 #define __ASM_ARM_SUSPEND_H
 
+#include <linux/types.h>
+
 struct sleep_save_sp {
 	u32 *save_ptr_stash;
 	u32 save_ptr_stash_phys;
-- 
2.13.2

Re: [PATCH 2/2] ARM: pm: add missing types include

[Pavel Machek]

On Tue 2017-07-04 15:25:42, Johan Hovold wrote:
> Add missing types.h include to make the suspend header self-contained
> and avoid compilation breakage due to include-directive ordering.
> 
> Signed-off-by: Johan Hovold <johan@kernel.org>

Acked-by: Pavel Machek <pavel@ucw.cz>

> +++ b/arch/arm/include/asm/suspend.h
>  #define __ASM_ARM_SUSPEND_H
>  
> +#include <linux/types.h>
> +
>  struct sleep_save_sp {

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: [PATCH 0/2] ARM: add missing includes to header files

[Russell King - ARM Linux]

On Tue, Jul 04, 2017 at 03:25:40PM +0200, Johan Hovold wrote:
> Add two missing include directives to two header files to avoid
> compile breakage when the required symbols have not already been
> defined.
> 
> The missing SCU include broke compilation of the (not-yet-merged)
> suspend support for am335x when !CONFIG_HAVE_ARM_SCU for example:
> 
> 	https://lkml.kernel.org/r/20170704131441.GH27842@localhost

These look reasonable, please send them to the patch system for merging
after this merge window, thanks.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

Re: [PATCH 0/2] ARM: add missing includes to header files

[Johan Hovold]

On Thu, Jul 06, 2017 at 04:16:07PM +0100, Russell King - ARM Linux wrote:
> On Tue, Jul 04, 2017 at 03:25:40PM +0200, Johan Hovold wrote:
> > Add two missing include directives to two header files to avoid
> > compile breakage when the required symbols have not already been
> > defined.
> > 
> > The missing SCU include broke compilation of the (not-yet-merged)
> > suspend support for am335x when !CONFIG_HAVE_ARM_SCU for example:
> > 
> > 	https://lkml.kernel.org/r/20170704131441.GH27842@localhost
> 
> These look reasonable, please send them to the patch system for merging
> after this merge window, thanks.

These two are now in your patch tracker (since a week).

Thanks,
Johan