From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [RFC][PATCH] thunderbolt: icm: Ignore mailbox errors in
 icm_suspend()
Date: Tue, 25 Jul 2017 13:00:12 +0300
Message-ID: <20170725100012.GH2369@lahna.fi.intel.com>
References: <4063610.TqANq0McE8@aspire.rjw.lan>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-pm-owner@vger.kernel.org>
Received: from mga14.intel.com ([192.55.52.115]:11667 "EHLO mga14.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751325AbdGYKAQ (ORCPT <rfc822;linux-pm@vger.kernel.org>);
        Tue, 25 Jul 2017 06:00:16 -0400
Content-Disposition: inline
In-Reply-To: <4063610.TqANq0McE8@aspire.rjw.lan>
Sender: linux-pm-owner@vger.kernel.org
List-Id: linux-pm@vger.kernel.org
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: LKML <linux-kernel@vger.kernel.org>, Linux PM <linux-pm@vger.kernel.org>, Andreas Noever <andreas.noever@gmail.com>, Michael Jamet <michael.jamet@intel.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>

On Tue, Jul 25, 2017 at 01:31:00AM +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> On one of my test machines nhi_mailbox_cmd() called from icm_suspend()
> times out and returnes an error which then is propagated to the
> caller and causes the entire system suspend to be aborted which isn't
> very useful.
> 
> Instead of aborting system suspend, print the error into the log
> and continue.

I agree, it should not prevent suspend but I wonder why it fails in the
first place? Can you check what is the return value?