Re: [RFC v1 1/6] power: supply: bq27xxx: Create single chip data table

[Sebastian Reichel <sebastian.reichel@collabora.co.uk>]

[-- Attachment #1: Type: text/plain, Size: 1279 bytes --]

Hi,

On Sat, Jul 08, 2017 at 07:16:55PM -0700, Liam Breck wrote:
> From: Liam Breck <kernel@networkimprov.net>
> 
> To support new features which require different data for each chip, we
> unify the bq27xxx_regs and bq27xxx_battery_props tables into a single one.
> 
> No functional changes to the driver.

Looks good to me except for one thing.

> [...]
> +#define BQ27XXX_DATA(ref) {			\
> +	.regs  = bq27##ref##_regs,		\
> +	.props = bq27##ref##_props,		\
> +	.props_size = ARRAY_SIZE(bq27##ref##_props) }
>
> [...]
>
> +	[BQ27000]   = BQ27XXX_DATA(000),
> +	[BQ27010]   = BQ27XXX_DATA(010),
> +	[BQ2750X]   = BQ27XXX_DATA(50x),
> +	[BQ2751X]   = BQ27XXX_DATA(51x),
> +	[BQ27500]   = BQ27XXX_DATA(500),
> +	[BQ27510G1] = BQ27XXX_DATA(510g1),
> +	[BQ27510G2] = BQ27XXX_DATA(510g2),
> +	[BQ27510G3] = BQ27XXX_DATA(510g3),
> +	[BQ27520G1] = BQ27XXX_DATA(520g1),
> +	[BQ27520G2] = BQ27XXX_DATA(520g2),
> +	[BQ27520G3] = BQ27XXX_DATA(520g3),
> +	[BQ27520G4] = BQ27XXX_DATA(520g4),
> +	[BQ27530]   = BQ27XXX_DATA(530),
> +	[BQ27541]   = BQ27XXX_DATA(541),
> +	[BQ27545]   = BQ27XXX_DATA(545),
> +	[BQ27421]   = BQ27XXX_DATA(421),
>  };

I would prefer to use ##ref##_regs and ##ref##_props above
and add the bq27 prefix here.

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]