From: Viresh Kumar <viresh.kumar@linaro.org>
To: Saravana Kannan <skannan@codeaurora.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
linux-pm@vger.kernel.org, Rafael Wysocki <rjw@rjwysocki.net>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
eas-dev@lists.linaro.org, smuckle.linux@gmail.com,
Len Brown <lenb@kernel.org>
Subject: Re: [Eas-dev] [PATCH V3 1/3] sched: cpufreq: Allow remote cpufreq callbacks
Date: Thu, 27 Jul 2017 09:00:59 +0530 [thread overview]
Message-ID: <20170727033059.GD352@vireshk-i7> (raw)
In-Reply-To: <597902DA.8060608@codeaurora.org>
On 26-07-17, 14:00, Saravana Kannan wrote:
> No, the alternative is to pass it on to the CPU freq driver and let it
> decide what it wants to do. That's the whole point if having a CPU freq
> driver -- so that the generic code doesn't need to care about HW specific
> details. Which is the point I was making in an earlier email to Viresh's
> patch -- we shouldn't be doing any CPU check for the call backs at the
> scheduler or ever governor level.
>
> That would simplify this whole thing by deleting a bunch of code. And having
> much simpler checks in those drivers that actually have to deal with their
> HW specific details.
So what you are saying is that we go and update (almost) every cpufreq
driver we have today and make their ->target() callbacks return early
if they don't support switching frequency remotely ? Is that really
simplifying anything?
The core already has most of the data required and I believe that we
need to handle it in the governor's code as is handled in this series.
To solve the problem that you have been reporting (update from any
CPU), we need something like this which I earlier suggested and I
will come back to it after this series is gone. Don't want to
complicate things here unnecessarily.
https://marc.info/?l=linux-kernel&m=148906012827786&w=2
--
viresh
next prev parent reply other threads:[~2017-07-27 3:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 6:44 [PATCH V3 0/3] sched: cpufreq: Allow remote callbacks Viresh Kumar
2017-07-13 6:44 ` [PATCH V3 1/3] sched: cpufreq: Allow remote cpufreq callbacks Viresh Kumar
2017-07-21 13:03 ` Peter Zijlstra
2017-07-24 11:01 ` Viresh Kumar
2017-07-24 13:47 ` Peter Zijlstra
2017-07-26 6:29 ` Viresh Kumar
2017-07-26 8:12 ` Peter Zijlstra
2017-07-26 17:26 ` Rafael J. Wysocki
2017-07-26 21:00 ` [Eas-dev] " Saravana Kannan
2017-07-27 3:30 ` Viresh Kumar [this message]
2017-07-27 19:55 ` Saravana Kannan
2017-07-28 4:33 ` Joel Fernandes (Google)
2017-07-28 6:00 ` Viresh Kumar
2017-07-28 21:05 ` Saravana Kannan
2017-07-31 3:58 ` Viresh Kumar
2017-07-13 6:44 ` [PATCH V3 2/3] cpufreq: schedutil: Process remote callback for shared policies Viresh Kumar
2017-07-14 2:02 ` [Eas-dev] " Saravana Kannan
2017-07-14 5:03 ` Viresh Kumar
2017-07-20 13:58 ` Peter Zijlstra
2017-07-20 12:22 ` Peter Zijlstra
2017-07-20 15:11 ` Sudeep Holla
2017-07-26 20:56 ` Saravana Kannan
2017-07-13 6:44 ` [PATCH V3 3/3] cpufreq: governor: " Viresh Kumar
2017-07-13 15:17 ` [PATCH V3 0/3] sched: cpufreq: Allow remote callbacks Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170727033059.GD352@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=eas-dev@lists.linaro.org \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=skannan@codeaurora.org \
--cc=smuckle.linux@gmail.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox