From: Darren Hart <dvhart@infradead.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Mario Limonciello <mario.limonciello@dell.com>,
AceLan Kao <acelan.kao@canonical.com>,
linux-pm@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
platform-driver-x86@vger.kernel.org, Len Brown <lenb@kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH] intel-vbtn: match power button on press rather than release
Date: Sun, 6 Aug 2017 16:24:18 -0700 [thread overview]
Message-ID: <20170806232418.GA29692@fury> (raw)
In-Reply-To: <1700343.1Fm4iKlbcW@aspire.rjw.lan>
On Sun, Aug 06, 2017 at 12:20:22AM +0200, Rafael Wysocki wrote:
> On Saturday, August 5, 2017 10:57:53 PM CEST Darren Hart wrote:
> > On Sat, Aug 05, 2017 at 01:30:20AM +0200, Rafael Wysocki wrote:
> > > On Friday, August 4, 2017 7:29:53 PM CEST Darren Hart wrote:
> > > > On Fri, Aug 04, 2017 at 12:00:06PM -0500, Mario Limonciello wrote:
> > > > > This fixes a problem where the system gets stuck in a loop
> > > > > unable to wakeup via power button in s2idle.
> > > > >
> > > > > The problem happens because:
> > > > > - press power button:
> > > > > - system emits 0xc0 (power press), event ignored
> > > > > - system emits 0xc1 (power release), event processed,
> > > > > emited as KEY_POWER
> > > > > - set wakeup_mode to true
> > > > > - system goes to s2idle
> > > > > - press power button
> > > > > - system emits 0xc0 (power press), wakeup_mode is true,
> > > > > system wakes
> > > > > - system emits 0xc1 (power release), event processed,
> > > > > emited as KEY_POWER
> > > > > - system goes to s2idle again
> > > > >
> > > > > To avoid this situation, process the presses (which matches what
> > > > > intel-hid does too).
> > > > >
> > > > > Verified on an Dell XPS 9365
> > > > >
> > > > > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
> > > >
> > > > This looks good to me - responding to the release is non-intuitive IMHO
> > > > anyway. I'd like to see agreement from AceLan, but this should go into
> > > > the 4.13 rc cycle (at rc3 currently).
> > >
> > > Yes, it should, and I'm not sure if the original author's opinion matters here.
> > >
> > > The patch makes sense to everyone involved and fixes an annoying issue, so
> > > I don't see any real arguments against applying it.
> > >
> > > Please feel free to add my ACK to it if that helps.
> >
> > I always try to give those in MAINTAINERS a chance to respond, but I will queue
> > this up to fixes now.
>
> Thanks!
Rafael,
Merged to mainline (in case you were waiting on this for the dependent
patch you mentioned).
--
Darren Hart
VMware Open Source Technology Center
next prev parent reply other threads:[~2017-08-06 23:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-04 17:00 [PATCH] intel-vbtn: match power button on press rather than release Mario Limonciello
2017-08-04 17:29 ` Darren Hart
2017-08-04 23:30 ` Rafael J. Wysocki
2017-08-05 20:57 ` Darren Hart
2017-08-05 22:20 ` Rafael J. Wysocki
2017-08-06 23:24 ` Darren Hart [this message]
2017-08-07 0:38 ` Rafael J. Wysocki
2017-08-07 0:59 ` AceLan Kao
2017-08-07 3:54 ` Darren Hart
2017-09-16 13:45 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170806232418.GA29692@fury \
--to=dvhart@infradead.org \
--cc=acelan.kao@canonical.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@dell.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).