Re: [RFC v2 2/5] power: supply: bq27xxx: Add chip IDs for previously shadowed chips

[Sebastian Reichel <sre@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1581 bytes --]

Hi,

On Sat, Aug 12, 2017 at 10:56:09AM -0700, Liam Breck wrote:
> Hi Sebastian,
> 
> On Sat, Aug 12, 2017 at 8:02 AM, Sebastian Reichel <sre@kernel.org> wrote:
> > Hi,
> >
> > On Sun, Aug 06, 2017 at 11:22:13PM -0700, Liam Breck wrote:
> >> From: Liam Breck <kernel@networkimprov.net>
> >>
> >> For the existing feature set, these chips act like ones already listed,
> >> so they had been given false but functional IDs. We will be adding features
> >> which obsolete that shadowing, so the following IDs are added:
> >> BQ2752X, 531, 542, 546, 742, 425, 441, 621
> >
> > Patch looks ok, but the patch description does not match the patch?
> 
> Does this clarify it?
> 
> For the existing driver features, the chips below act like others already ID'd,
> so they had been given false but functional IDs. We will be adding features
> which obsolete that ID shadowing, so the following IDs are added:
> BQ2752X, 531, 542, 546, 742, 425, 441, 621
>
> >> Chip-specific features are now tracked by BQ27XXX_O_* flags in di->opts.
> >>
> >> No functional changes to the driver.

I was too tired when I read that yesterday in the airplane. I'm
fine with both texts and throw in a third suggestion:

Add explicit chip IDs for some chips, that are currently using a
compatible chip ID. This is required due to incompatible advanced
features, that will be added later. To keep chip handling simple,
the chip features are now tracked using flags in di->opts. Driver
functionality is not supposed to change.

Choose the one you like most.

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]