linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Luciano Coelho <luca@coelho.fi>
Cc: jikos@kernel.org, linux-wireless@vger.kernel.org,
	luciano.coelho@intel.com, linux-kernel@vger.kernel.org,
	linuxwifi@intel.com, rui.zhang@intel.com, edubezval@gmail.com,
	linux-pm@vger.kernel.org, david.weinehall@intel.com,
	johannes.berg@intel.com, sara.sharon@intel.com,
	emmanuel.grumbach@intel.com
Subject: Re: [v2] iwlwifi: pcie: move rx workqueue initialization to iwl_trans_pcie_alloc()
Date: Thu, 24 Aug 2017 13:50:23 +0000 (UTC)	[thread overview]
Message-ID: <20170824135023.EB43F60712@smtp.codeaurora.org> (raw)
In-Reply-To: <20170822073729.4856-1-luca@coelho.fi>

Luciano Coelho <luca@coelho.fi> wrote:

> From: Luca Coelho <luciano.coelho@intel.com>
> 
> Work queues cannot be allocated when a mutex is held because the mutex
> may be in use and that would make it sleep.  Doing so generates the
> following splat with 4.13+:
> 
> [   19.513298] ======================================================
> [   19.513429] WARNING: possible circular locking dependency detected
> [   19.513557] 4.13.0-rc5+ #6 Not tainted
> [   19.513638] ------------------------------------------------------
> [   19.513767] cpuhp/0/12 is trying to acquire lock:
> [   19.513867]  (&tz->lock){+.+.+.}, at: [<ffffffff924afebb>] thermal_zone_get_temp+0x5b/0xb0
> [   19.514047]
> [   19.514047] but task is already holding lock:
> [   19.514166]  (cpuhp_state){+.+.+.}, at: [<ffffffff91cc4baa>] cpuhp_thread_fun+0x3a/0x210
> [   19.514338]
> [   19.514338] which lock already depends on the new lock.
> 
> This lock dependency already existed with previous kernel versions,
> but it was not detected until commit 49dfe2a67797 ("cpuhotplug: Link
> lock stacks for hotplug callbacks") was introduced.
> 
> Reported-by: David Weinehall <david.weinehall@intel.com>
> Reported-by: Jiri Kosina <jikos@kernel.org>
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>

Patch applied to wireless-drivers.git, thanks.

10a54d8196d1 iwlwifi: pcie: move rx workqueue initialization to iwl_trans_pcie_alloc()

-- 
https://patchwork.kernel.org/patch/9914349/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  parent reply	other threads:[~2017-08-24 13:50 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-31 11:18 x86/thermal: AB-BA dependency between mvm->mutex and tz->lock Jiri Kosina
2017-08-03  9:10 ` Jiri Kosina
2017-08-03  9:43   ` [linuxwifi] " Coelho, Luciano
2017-08-03 10:02     ` Kalle Valo
2017-08-03 11:28       ` Coelho, Luciano
2017-08-03 11:34         ` Jiri Kosina
2017-08-03 13:09           ` Jiri Kosina
2017-08-17 13:38             ` Jiri Kosina
2017-08-17 14:02               ` Coelho, Luciano
2017-08-22  7:32               ` [PATCH] iwlwifi: pcie: move rx workqueue initialization to iwl_trans_pcie_alloc() Luca Coelho
2017-08-22  7:37               ` [PATCH v2] " Luca Coelho
2017-08-24  6:00                 ` Luca Coelho
2017-08-24 19:56                   ` Jiri Kosina
2017-08-24 20:00                     ` Luca Coelho
2017-08-29  8:19                       ` Kalle Valo
2017-09-04 11:43                       ` Jiri Kosina
2017-09-04 11:44                         ` Luca Coelho
2017-08-24 13:50                 ` Kalle Valo [this message]
2017-08-30 14:57                 ` David Weinehall
2017-08-31  6:11                   ` Luca Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170824135023.EB43F60712@smtp.codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=david.weinehall@intel.com \
    --cc=edubezval@gmail.com \
    --cc=emmanuel.grumbach@intel.com \
    --cc=jikos@kernel.org \
    --cc=johannes.berg@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linuxwifi@intel.com \
    --cc=luca@coelho.fi \
    --cc=luciano.coelho@intel.com \
    --cc=rui.zhang@intel.com \
    --cc=sara.sharon@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).