From: Tony Lindgren <tony@atomide.com>
To: Liam Breck <liam@networkimprov.net>
Cc: Sebastian Reichel <sre@kernel.org>,
linux-pm@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
Liam Breck <kernel@networkimprov.net>
Subject: Re: [PATCH v2 1/5] power: bq24190_charger: Add ti,bq24192i to devicetree table
Date: Fri, 25 Aug 2017 13:28:16 -0700 [thread overview]
Message-ID: <20170825202815.GT3930@atomide.com> (raw)
In-Reply-To: <20170807195420.20767-2-liam@networkimprov.net>
* Liam Breck <liam@networkimprov.net> [170807 12:55]:
> From: Liam Breck <kernel@networkimprov.net>
> --- a/drivers/power/supply/bq24190_charger.c
> +++ b/drivers/power/supply/bq24190_charger.c
> #else
> -static const struct of_device_id bq24190_of_match[] = {
> - { },
> -};
> +static const struct of_device_id bq24190_of_match[] = { {} };
> #endif
Maybe check what checkpatch says about this one?
It might actually prefer what we have now. You should
also mention it in the commit message or just drop that
change as people could complain it's an unrelated
change.
Regards,
Tony
next prev parent reply other threads:[~2017-08-25 20:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 19:54 [PATCH v2 0/5] BQ24190 devicetree config Liam Breck
2017-08-07 19:54 ` [PATCH v2 1/5] power: bq24190_charger: Add ti,bq24192i to devicetree table Liam Breck
2017-08-25 20:28 ` Tony Lindgren [this message]
2017-08-07 19:54 ` [PATCH v2 2/5] devicetree: power: Add docs for TI BQ24190 battery charger Liam Breck
[not found] ` <20170807195420.20767-3-liam-RYWXG+zxWwBdeoIcmNTgJF6hYfS7NtTn@public.gmane.org>
2017-08-11 2:50 ` Rob Herring
2017-08-11 21:57 ` Liam Breck
2017-08-12 16:42 ` Sebastian Reichel
2017-08-12 19:00 ` Liam Breck
[not found] ` <CAKvHMgR+GxSqhy+iwdYmku2600HzoF__oXV7_w72ZJg-aK7O-Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-08-16 15:47 ` Tony Lindgren
2017-08-16 20:11 ` Liam Breck
[not found] ` <CAKvHMgTvVMsvmyi0o89m1SfS9A4U1GbNuU05Tkt6C0ARR9NyWw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-08-16 21:06 ` Tony Lindgren
2017-08-16 21:16 ` Liam Breck
[not found] ` <CAKvHMgTJjTxffoP4Kt=KzGvCQ-BihLeQn3i4TaF4OBSXV7i6TA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-08-18 0:16 ` Tony Lindgren
2017-08-25 20:29 ` Tony Lindgren
2017-08-07 19:54 ` [PATCH v2 3/5] power: bq24190_charger: Enable devicetree config Liam Breck
2017-08-07 19:54 ` [PATCH v2 4/5] power: bq24190_charger: Add property system-minimum-microvolt Liam Breck
2017-08-07 19:54 ` [PATCH v2 5/5] power: bq24190_charger: Add power_supply_battery_info support Liam Breck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170825202815.GT3930@atomide.com \
--to=tony@atomide.com \
--cc=hdegoede@redhat.com \
--cc=kernel@networkimprov.net \
--cc=liam@networkimprov.net \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).