From: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
To: Marek Belisko <marek.belisko@open-nandra.com>
Cc: robh+dt@kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, hns@goldelico.com, pavel@ucw.cz,
Marek Belisko <marek.belisko@gmail.com>
Subject: Re: [RFC PATCH 5/5] power: generic-adc-battery: Add capacity handling
Date: Tue, 29 Aug 2017 12:11:47 +0200 [thread overview]
Message-ID: <20170829101147.debhadzyfrxhkrvt@earth> (raw)
In-Reply-To: <1501620926-22669-6-git-send-email-marek.belisko@open-nandra.com>
[-- Attachment #1: Type: text/plain, Size: 1695 bytes --]
Hi,
On Tue, Aug 01, 2017 at 10:55:26PM +0200, Marek Belisko wrote:
> From: Marek Belisko <marek.belisko@gmail.com>
>
> Signed-off-by: Marek Belisko <marek.belisko@gmail.com>
> ---
> drivers/power/supply/generic-adc-battery.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/power/supply/generic-adc-battery.c b/drivers/power/supply/generic-adc-battery.c
> index 0d27b59..9ce51d2 100644
> --- a/drivers/power/supply/generic-adc-battery.c
> +++ b/drivers/power/supply/generic-adc-battery.c
> @@ -24,6 +24,7 @@
> #include <linux/iio/types.h>
> #include <linux/power/generic-adc-battery.h>
> #include <linux/of_gpio.h>
> +#include <linux/power/generic-fuel-gauge.h>
>
> #define JITTER_DEFAULT 10 /* hope 10ms is enough */
>
> @@ -81,6 +82,7 @@ static const enum power_supply_property gab_props[] = {
> POWER_SUPPLY_PROP_VOLTAGE_MAX_DESIGN,
> POWER_SUPPLY_PROP_MODEL_NAME,
> POWER_SUPPLY_PROP_TEMP,
> + POWER_SUPPLY_PROP_CAPACITY,
> };
>
> /*
> @@ -202,6 +204,18 @@ static int gab_get_property(struct power_supply *psy,
> case POWER_SUPPLY_PROP_MODEL_NAME:
> val->strval = bat_info->name;
> break;
> + case POWER_SUPPLY_PROP_CAPACITY:
> + {
> + int ret, curr, voltage;
> +
> + ret = read_channel(adc_bat, POWER_SUPPLY_PROP_CURRENT_NOW, &curr);
> + ret |= read_channel(adc_bat, POWER_SUPPLY_PROP_VOLTAGE_NOW, &voltage);
> + if (ret < 0)
> + goto err;
> +
> + val->intval = fuel_level_LiIon(voltage, curr, 10);
> + }
> + break;
> default:
> return -EINVAL;
> }
Without patch description: See Last Question in
Documentation/power/power_supply_class.txt
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-08-29 10:11 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 20:55 [RFC PATCH 0/5] Add formula for LiIon batteries to compute capacity Marek Belisko
2017-08-01 20:55 ` [RFC PATCH 1/5] dt-bindings: power: Add battery types Marek Belisko
2017-08-02 11:38 ` Pavel Machek
2017-08-02 11:43 ` Pavel Machek
2017-08-02 11:47 ` Belisko Marek
2017-08-01 20:55 ` [RFC PATCH 2/5] power: generic-adc-battery: Parse more properties from DT Marek Belisko
2017-08-02 11:56 ` Pavel Machek
2017-08-02 11:57 ` Belisko Marek
2017-08-29 9:45 ` Sebastian Reichel
2017-08-01 20:55 ` [RFC PATCH 3/5] power/generic-adc-battery: Add support for temperature and add check for charge from iio current channel Marek Belisko
2017-08-29 9:54 ` Sebastian Reichel
2017-08-01 20:55 ` [RFC PATCH 4/5] power: Add formula for computing LiIon State of Charge from Voltage Marek Belisko
2017-08-01 20:55 ` [RFC PATCH 5/5] power: generic-adc-battery: Add capacity handling Marek Belisko
2017-08-29 10:11 ` Sebastian Reichel [this message]
2017-09-08 11:32 ` libbattery was " Pavel Machek
2017-09-08 13:15 ` H. Nikolaus Schaller
2017-10-18 12:28 ` Pavel Machek
2017-10-18 12:48 ` H. Nikolaus Schaller
2017-10-18 13:09 ` Pavel Machek
2017-10-18 13:22 ` Tony Lindgren
2017-10-18 13:56 ` Pavel Machek
2017-10-18 15:52 ` H. Nikolaus Schaller
2017-10-18 16:13 ` Pavel Machek
2017-10-18 16:48 ` H. Nikolaus Schaller
2017-10-18 15:47 ` H. Nikolaus Schaller
2017-10-19 16:24 ` Tony Lindgren
2017-10-19 16:55 ` H. Nikolaus Schaller
2017-10-19 17:06 ` Tony Lindgren
2017-10-19 17:20 ` H. Nikolaus Schaller
2017-10-19 17:33 ` Ladislav Michl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170829101147.debhadzyfrxhkrvt@earth \
--to=sebastian.reichel@collabora.co.uk \
--cc=hns@goldelico.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=marek.belisko@gmail.com \
--cc=marek.belisko@open-nandra.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox