From: Sebastian Reichel <sre@kernel.org>
To: Liam Breck <liam@networkimprov.net>
Cc: "H. Nikolaus Schaller" <hns@goldelico.com>,
"Pali Rohár" <pali.rohar@gmail.com>,
"Andrew F. Davis" <afd@ti.com>,
linux-pm@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
"Discussions about the Letux Kernel"
<letux-kernel@openphoenux.org>,
kernel@pyra-handheld.com
Subject: Re: [PATCH resend v2] power: supply: bq27xxx: enable writing capacity values for bq27421
Date: Wed, 30 Aug 2017 02:37:45 +0200 [thread overview]
Message-ID: <20170830003745.6iimg4zn2cuybp7n@earth> (raw)
In-Reply-To: <CAKvHMgQDcgabM3UogXE3L07n9yiHgD3FfJ5GCOqkAk1=SA2A=Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1053 bytes --]
Hi,
On Tue, Aug 29, 2017 at 01:20:27PM -0700, Liam Breck wrote:
> Hi Nikolaus, thanks for the patch...
>
> On Tue, Aug 29, 2017 at 1:10 PM, H. Nikolaus Schaller <hns@goldelico.com> wrote:
> > Tested on Pyra prototype with bq27421.
> >
> > Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> > ---
> > drivers/power/supply/bq27xxx_battery.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c
> > index b6c3120ca5ad..e3c878ef7c7e 100644
> > --- a/drivers/power/supply/bq27xxx_battery.c
> > +++ b/drivers/power/supply/bq27xxx_battery.c
> > @@ -688,7 +688,7 @@ static struct bq27xxx_dm_reg bq27545_dm_regs[] = {
> > #define bq27545_dm_regs 0
> > #endif
> >
> > -#if 0 /* not yet tested */
> > +#if 1 /* tested on Pyra */
> > static struct bq27xxx_dm_reg bq27421_dm_regs[] = {
>
> I think we can drop the #if and #else...#endif so it's just the
> dm_regs table, as with bq27425.
Yes, please.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-08-30 0:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-29 20:10 [PATCH resend v2] power: supply: bq27xxx: enable writing capacity values for bq27421 H. Nikolaus Schaller
2017-08-29 20:20 ` Liam Breck
2017-08-30 0:37 ` Sebastian Reichel [this message]
2017-08-30 9:30 ` H. Nikolaus Schaller
2017-08-30 11:24 ` Liam Breck
2017-08-31 6:58 ` H. Nikolaus Schaller
2017-08-31 8:58 ` Liam Breck
2017-08-31 9:35 ` H. Nikolaus Schaller
2017-08-31 20:19 ` Liam Breck
2017-09-08 17:38 ` H. Nikolaus Schaller
2017-09-08 17:40 ` Pali Rohár
2017-09-08 17:44 ` H. Nikolaus Schaller
2017-09-08 20:19 ` Liam Breck
2017-09-08 20:28 ` H. Nikolaus Schaller
2017-09-08 20:57 ` Liam Breck
2017-09-08 22:08 ` H. Nikolaus Schaller
2017-09-09 20:21 ` [PATCH resend v2] power: supply: bq27xxx: enable writing capacity values for bq27421 + bq27500 H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170830003745.6iimg4zn2cuybp7n@earth \
--to=sre@kernel.org \
--cc=afd@ti.com \
--cc=hns@goldelico.com \
--cc=kernel@pyra-handheld.com \
--cc=letux-kernel@openphoenux.org \
--cc=liam@networkimprov.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pali.rohar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox