* [PATCH] drivers: cpuidle: Fix checkpatch error and warnings
@ 2017-09-07 10:23 gaurav jindal
2017-09-07 10:33 ` Joe Perches
0 siblings, 1 reply; 5+ messages in thread
From: gaurav jindal @ 2017-09-07 10:23 UTC (permalink / raw)
To: rjw, daniel.lezcano; +Cc: linux-pm, linux-kernel, toddpoynor
This patch fixes the below checkpatch errors and warnings in
drivers/cpuidle/cpuidle.c
WARNING: line over 80 characters
#311: FILE: drivers/cpuidle/cpuidle.c:311:
+ /* Make sure all changes finished before we switch to new idle */
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#343: FILE: drivers/cpuidle/cpuidle.c:343:
+EXPORT_SYMBOL_GPL(cpuidle_pause_and_lock);
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#354: FILE: drivers/cpuidle/cpuidle.c:354:
+EXPORT_SYMBOL_GPL(cpuidle_resume_and_unlock);
ERROR: do not use assignment in if condition
#402: FILE: drivers/cpuidle/cpuidle.c:402:
+ if (cpuidle_curr_governor->enable &&
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#419: FILE: drivers/cpuidle/cpuidle.c:419:
+EXPORT_SYMBOL_GPL(cpuidle_enable_device);
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#447: FILE: drivers/cpuidle/cpuidle.c:447:
+EXPORT_SYMBOL_GPL(cpuidle_disable_device);
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#537: FILE: drivers/cpuidle/cpuidle.c:537:
+EXPORT_SYMBOL_GPL(cpuidle_register_device);
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#561: FILE: drivers/cpuidle/cpuidle.c:561:
+EXPORT_SYMBOL_GPL(cpuidle_unregister_device);
Signed-off-by: gaurav jindal<gauravjindal1104@gmail.com>
---
diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
index 60bb64f..a42148e 100644
--- a/drivers/cpuidle/cpuidle.c
+++ b/drivers/cpuidle/cpuidle.c
@@ -308,7 +308,10 @@ void cpuidle_reflect(struct cpuidle_device *dev, int index)
void cpuidle_install_idle_handler(void)
{
if (enabled_devices) {
- /* Make sure all changes finished before we switch to new idle */
+ /*
+ * Make sure all changes finished before we switch to
+ * new idle
+ */
smp_wmb();
initialized = 1;
}
@@ -339,7 +342,6 @@ void cpuidle_pause_and_lock(void)
mutex_lock(&cpuidle_lock);
cpuidle_uninstall_idle_handler();
}
-
EXPORT_SYMBOL_GPL(cpuidle_pause_and_lock);
/**
@@ -350,7 +352,6 @@ void cpuidle_resume_and_unlock(void)
cpuidle_install_idle_handler();
mutex_unlock(&cpuidle_lock);
}
-
EXPORT_SYMBOL_GPL(cpuidle_resume_and_unlock);
/* Currently used in suspend/resume path to suspend cpuidle */
@@ -399,9 +400,12 @@ int cpuidle_enable_device(struct cpuidle_device *dev)
if (ret)
return ret;
- if (cpuidle_curr_governor->enable &&
- (ret = cpuidle_curr_governor->enable(drv, dev)))
- goto fail_sysfs;
+ if (cpuidle_curr_governor->enable) {
+
+ ret = cpuidle_curr_governor->enable(drv, dev);
+ if (ret)
+ goto fail_sysfs;
+ }
smp_wmb();
@@ -415,7 +419,6 @@ int cpuidle_enable_device(struct cpuidle_device *dev)
return ret;
}
-
EXPORT_SYMBOL_GPL(cpuidle_enable_device);
/**
@@ -443,7 +446,6 @@ void cpuidle_disable_device(struct cpuidle_device *dev)
cpuidle_remove_device_sysfs(dev);
enabled_devices--;
}
-
EXPORT_SYMBOL_GPL(cpuidle_disable_device);
static void __cpuidle_unregister_device(struct cpuidle_device *dev)
@@ -533,7 +535,6 @@ int cpuidle_register_device(struct cpuidle_device *dev)
__cpuidle_unregister_device(dev);
goto out_unlock;
}
-
EXPORT_SYMBOL_GPL(cpuidle_register_device);
/**
@@ -557,7 +558,6 @@ void cpuidle_unregister_device(struct cpuidle_device *dev)
cpuidle_resume_and_unlock();
}
-
EXPORT_SYMBOL_GPL(cpuidle_unregister_device);
/**
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] drivers: cpuidle: Fix checkpatch error and warnings
2017-09-07 10:23 [PATCH] drivers: cpuidle: Fix checkpatch error and warnings gaurav jindal
@ 2017-09-07 10:33 ` Joe Perches
2017-09-07 12:40 ` gaurav jindal
0 siblings, 1 reply; 5+ messages in thread
From: Joe Perches @ 2017-09-07 10:33 UTC (permalink / raw)
To: gaurav jindal, rjw, daniel.lezcano; +Cc: linux-pm, linux-kernel, toddpoynor
On Thu, 2017-09-07 at 15:53 +0530, gaurav jindal wrote:
> This patch fixes the below checkpatch errors and warnings in
> drivers/cpuidle/cpuidle.c
If you are going to propose a checkpatch only patch,
please run your proposed patch through checkpatch.
> diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
[]
>
> @@ -399,9 +400,12 @@ int cpuidle_enable_device(struct cpuidle_device *dev)
> if (ret)
> return ret;
>
> - if (cpuidle_curr_governor->enable &&
> - (ret = cpuidle_curr_governor->enable(drv, dev)))
> - goto fail_sysfs;
> + if (cpuidle_curr_governor->enable) {
> +
> + ret = cpuidle_curr_governor->enable(drv, dev);
> + if (ret)
> + goto fail_sysfs;
> + }
checkpatch should complain here about unnecessary
blank line after open brace
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drivers: cpuidle: Fix checkpatch error and warnings
2017-09-07 10:33 ` Joe Perches
@ 2017-09-07 12:40 ` gaurav jindal
2017-09-07 23:18 ` Rafael J. Wysocki
0 siblings, 1 reply; 5+ messages in thread
From: gaurav jindal @ 2017-09-07 12:40 UTC (permalink / raw)
To: Joe Perches, rjw, daniel.lezcano; +Cc: linux-pm, linux-kernel, toddpoynor
this patch fixes the below checkpatch errors and warnings in
drivers/cpuidle/cpuidle.c
WARNING: line over 80 characters
#311: FILE: drivers/cpuidle/cpuidle.c:311:
+ /* Make sure all changes finished before we switch to new idle */
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#343: FILE: drivers/cpuidle/cpuidle.c:343:
+EXPORT_SYMBOL_GPL(cpuidle_pause_and_lock);
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#354: FILE: drivers/cpuidle/cpuidle.c:354:
+EXPORT_SYMBOL_GPL(cpuidle_resume_and_unlock);
ERROR: do not use assignment in if condition
#402: FILE: drivers/cpuidle/cpuidle.c:402:
+ if (cpuidle_curr_governor->enable &&
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#419: FILE: drivers/cpuidle/cpuidle.c:419:
+EXPORT_SYMBOL_GPL(cpuidle_enable_device);
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#447: FILE: drivers/cpuidle/cpuidle.c:447:
+EXPORT_SYMBOL_GPL(cpuidle_disable_device);
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#537: FILE: drivers/cpuidle/cpuidle.c:537:
+EXPORT_SYMBOL_GPL(cpuidle_register_device);
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#561: FILE: drivers/cpuidle/cpuidle.c:561:
+EXPORT_SYMBOL_GPL(cpuidle_unregister_device);
Signed-off-by:gaurav jindal<gauravjindal1104@gmail.com>
---
diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
index 60bb64f..a42148e 100644
--- a/drivers/cpuidle/cpuidle.c
+++ b/drivers/cpuidle/cpuidle.c
@@ -308,7 +308,10 @@ void cpuidle_reflect(struct cpuidle_device *dev, int index)
void cpuidle_install_idle_handler(void)
{
if (enabled_devices) {
- /* Make sure all changes finished before we switch to new idle */
+ /*
+ * Make sure all changes finished before we switch to
+ * new idle
+ */
smp_wmb();
initialized = 1;
}
@@ -339,7 +342,6 @@ void cpuidle_pause_and_lock(void)
mutex_lock(&cpuidle_lock);
cpuidle_uninstall_idle_handler();
}
-
EXPORT_SYMBOL_GPL(cpuidle_pause_and_lock);
/**
@@ -350,7 +352,6 @@ void cpuidle_resume_and_unlock(void)
cpuidle_install_idle_handler();
mutex_unlock(&cpuidle_lock);
}
-
EXPORT_SYMBOL_GPL(cpuidle_resume_and_unlock);
/* Currently used in suspend/resume path to suspend cpuidle */
@@ -399,9 +400,12 @@ int cpuidle_enable_device(struct cpuidle_device *dev)
if (ret)
return ret;
- if (cpuidle_curr_governor->enable &&
- (ret = cpuidle_curr_governor->enable(drv, dev)))
- goto fail_sysfs;
+ if (cpuidle_curr_governor->enable) {
+ ret = cpuidle_curr_governor->enable(drv, dev);
+ if (ret)
+ goto fail_sysfs;
+ }
smp_wmb();
@@ -415,7 +419,6 @@ int cpuidle_enable_device(struct cpuidle_device *dev)
return ret;
}
-
EXPORT_SYMBOL_GPL(cpuidle_enable_device);
/**
@@ -443,7 +446,6 @@ void cpuidle_disable_device(struct cpuidle_device *dev)
cpuidle_remove_device_sysfs(dev);
enabled_devices--;
}
-
EXPORT_SYMBOL_GPL(cpuidle_disable_device);
static void __cpuidle_unregister_device(struct cpuidle_device *dev)
@@ -533,7 +535,6 @@ int cpuidle_register_device(struct cpuidle_device *dev)
__cpuidle_unregister_device(dev);
goto out_unlock;
}
-
EXPORT_SYMBOL_GPL(cpuidle_register_device);
/**
@@ -557,7 +558,6 @@ void cpuidle_unregister_device(struct cpuidle_device *dev)
cpuidle_resume_and_unlock();
}
-
EXPORT_SYMBOL_GPL(cpuidle_unregister_device);
/**
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] drivers: cpuidle: Fix checkpatch error and warnings
2017-09-07 12:40 ` gaurav jindal
@ 2017-09-07 23:18 ` Rafael J. Wysocki
2017-09-08 13:36 ` gaurav jindal
0 siblings, 1 reply; 5+ messages in thread
From: Rafael J. Wysocki @ 2017-09-07 23:18 UTC (permalink / raw)
To: gaurav jindal
Cc: Joe Perches, Rafael J. Wysocki, Daniel Lezcano, Linux PM,
Linux Kernel Mailing List, Todd Poynor
On Thu, Sep 7, 2017 at 2:40 PM, gaurav jindal
<gauravjindal1104@gmail.com> wrote:
> this patch fixes the below checkpatch errors and warnings in
> drivers/cpuidle/cpuidle.c
>
> WARNING: line over 80 characters
> #311: FILE: drivers/cpuidle/cpuidle.c:311:
> + /* Make sure all changes finished before we switch to new idle */
>
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> #343: FILE: drivers/cpuidle/cpuidle.c:343:
> +EXPORT_SYMBOL_GPL(cpuidle_pause_and_lock);
>
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> #354: FILE: drivers/cpuidle/cpuidle.c:354:
> +EXPORT_SYMBOL_GPL(cpuidle_resume_and_unlock);
>
> ERROR: do not use assignment in if condition
> #402: FILE: drivers/cpuidle/cpuidle.c:402:
> + if (cpuidle_curr_governor->enable &&
>
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> #419: FILE: drivers/cpuidle/cpuidle.c:419:
> +EXPORT_SYMBOL_GPL(cpuidle_enable_device);
>
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> #447: FILE: drivers/cpuidle/cpuidle.c:447:
> +EXPORT_SYMBOL_GPL(cpuidle_disable_device);
>
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> #537: FILE: drivers/cpuidle/cpuidle.c:537:
> +EXPORT_SYMBOL_GPL(cpuidle_register_device);
>
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> #561: FILE: drivers/cpuidle/cpuidle.c:561:
> +EXPORT_SYMBOL_GPL(cpuidle_unregister_device);
>
> Signed-off-by:gaurav jindal<gauravjindal1104@gmail.com>
>
> ---
>
> diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
> index 60bb64f..a42148e 100644
> --- a/drivers/cpuidle/cpuidle.c
> +++ b/drivers/cpuidle/cpuidle.c
> @@ -308,7 +308,10 @@ void cpuidle_reflect(struct cpuidle_device *dev, int index)
> void cpuidle_install_idle_handler(void)
> {
> if (enabled_devices) {
> - /* Make sure all changes finished before we switch to new idle */
> + /*
> + * Make sure all changes finished before we switch to
> + * new idle
> + */
> smp_wmb();
> initialized = 1;
> }
Don't do this.
The rest is fine by me.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drivers: cpuidle: Fix checkpatch error and warnings
2017-09-07 23:18 ` Rafael J. Wysocki
@ 2017-09-08 13:36 ` gaurav jindal
0 siblings, 0 replies; 5+ messages in thread
From: gaurav jindal @ 2017-09-08 13:36 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Joe Perches, Rafael J. Wysocki, Daniel Lezcano, Linux PM,
Linux Kernel Mailing List, Todd Poynor
This patch fixes the below checkpatch errors and warnings in
drivers/cpuidle/cpuidle.c
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#343: FILE: drivers/cpuidle/cpuidle.c:343:
+EXPORT_SYMBOL_GPL(cpuidle_pause_and_lock);
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#354: FILE: drivers/cpuidle/cpuidle.c:354:
+EXPORT_SYMBOL_GPL(cpuidle_resume_and_unlock);
ERROR: do not use assignment in if condition
#402: FILE: drivers/cpuidle/cpuidle.c:402:
+ if (cpuidle_curr_governor->enable &&
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#419: FILE: drivers/cpuidle/cpuidle.c:419:
+EXPORT_SYMBOL_GPL(cpuidle_enable_device);
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#447: FILE: drivers/cpuidle/cpuidle.c:447:
+EXPORT_SYMBOL_GPL(cpuidle_disable_device);
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#537: FILE: drivers/cpuidle/cpuidle.c:537:
+EXPORT_SYMBOL_GPL(cpuidle_register_device);
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#561: FILE: drivers/cpuidle/cpuidle.c:561:
+EXPORT_SYMBOL_GPL(cpuidle_unregister_device);
Signed-off-by: gaurav jindal<gauravjindal1104@gmail.com>
---
diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
index 60bb64f..f2be6dd 100644
--- a/drivers/cpuidle/cpuidle.c
+++ b/drivers/cpuidle/cpuidle.c
@@ -339,7 +339,6 @@ void cpuidle_pause_and_lock(void)
mutex_lock(&cpuidle_lock);
cpuidle_uninstall_idle_handler();
}
-
EXPORT_SYMBOL_GPL(cpuidle_pause_and_lock);
/**
@@ -350,7 +349,6 @@ void cpuidle_resume_and_unlock(void)
cpuidle_install_idle_handler();
mutex_unlock(&cpuidle_lock);
}
-
EXPORT_SYMBOL_GPL(cpuidle_resume_and_unlock);
/* Currently used in suspend/resume path to suspend cpuidle */
@@ -399,9 +397,11 @@ int cpuidle_enable_device(struct cpuidle_device *dev)
if (ret)
return ret;
- if (cpuidle_curr_governor->enable &&
- (ret = cpuidle_curr_governor->enable(drv, dev)))
- goto fail_sysfs;
+ if (cpuidle_curr_governor->enable) {
+ ret = cpuidle_curr_governor->enable(drv, dev);
+ if (ret)
+ goto fail_sysfs;
+ }
smp_wmb();
@@ -415,7 +415,6 @@ int cpuidle_enable_device(struct cpuidle_device *dev)
return ret;
}
-
EXPORT_SYMBOL_GPL(cpuidle_enable_device);
@@ -443,7 +442,6 @@ void cpuidle_disable_device(struct cpuidle_device *dev)
cpuidle_remove_device_sysfs(dev);
enabled_devices--;
}
-
EXPORT_SYMBOL_GPL(cpuidle_disable_device);
static void __cpuidle_unregister_device(struct cpuidle_device *dev)
@@ -533,7 +531,6 @@ int cpuidle_register_device(struct cpuidle_device *dev)
__cpuidle_unregister_device(dev);
goto out_unlock;
}
-
EXPORT_SYMBOL_GPL(cpuidle_register_device);
/**
@@ -557,7 +554,6 @@ void cpuidle_unregister_device(struct cpuidle_device *dev)
cpuidle_resume_and_unlock();
}
-
EXPORT_SYMBOL_GPL(cpuidle_unregister_device);
/**
On Fri, Sep 08, 2017 at 01:18:49AM +0200, Rafael J. Wysocki wrote:
> On Thu, Sep 7, 2017 at 2:40 PM, gaurav jindal
> <gauravjindal1104@gmail.com> wrote:
> > this patch fixes the below checkpatch errors and warnings in
> > drivers/cpuidle/cpuidle.c
> >
> > WARNING: line over 80 characters
> > #311: FILE: drivers/cpuidle/cpuidle.c:311:
> > + /* Make sure all changes finished before we switch to new idle */
> >
> > WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> > #343: FILE: drivers/cpuidle/cpuidle.c:343:
> > +EXPORT_SYMBOL_GPL(cpuidle_pause_and_lock);
> >
> > WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> > #354: FILE: drivers/cpuidle/cpuidle.c:354:
> > +EXPORT_SYMBOL_GPL(cpuidle_resume_and_unlock);
> >
> > ERROR: do not use assignment in if condition
> > #402: FILE: drivers/cpuidle/cpuidle.c:402:
> > + if (cpuidle_curr_governor->enable &&
> >
> > WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> > #419: FILE: drivers/cpuidle/cpuidle.c:419:
> > +EXPORT_SYMBOL_GPL(cpuidle_enable_device);
> >
> > WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> > #447: FILE: drivers/cpuidle/cpuidle.c:447:
> > +EXPORT_SYMBOL_GPL(cpuidle_disable_device);
> >
> > WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> > #537: FILE: drivers/cpuidle/cpuidle.c:537:
> > +EXPORT_SYMBOL_GPL(cpuidle_register_device);
> >
> > WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> > #561: FILE: drivers/cpuidle/cpuidle.c:561:
> > +EXPORT_SYMBOL_GPL(cpuidle_unregister_device);
> >
> > Signed-off-by:gaurav jindal<gauravjindal1104@gmail.com>
> >
> > ---
> >
> > diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
> > index 60bb64f..a42148e 100644
> > --- a/drivers/cpuidle/cpuidle.c
> > +++ b/drivers/cpuidle/cpuidle.c
> > @@ -308,7 +308,10 @@ void cpuidle_reflect(struct cpuidle_device *dev, int index)
> > void cpuidle_install_idle_handler(void)
> > {
> > if (enabled_devices) {
> > - /* Make sure all changes finished before we switch to new idle */
> > + /*
> > + * Make sure all changes finished before we switch to
> > + * new idle
> > + */
> > smp_wmb();
> > initialized = 1;
> > }
>
> Don't do this.
>
> The rest is fine by me.
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-09-08 13:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-07 10:23 [PATCH] drivers: cpuidle: Fix checkpatch error and warnings gaurav jindal
2017-09-07 10:33 ` Joe Perches
2017-09-07 12:40 ` gaurav jindal
2017-09-07 23:18 ` Rafael J. Wysocki
2017-09-08 13:36 ` gaurav jindal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).