From: Abhishek Goel <huntbag@linux.vnet.ibm.com>
To: trenn@suse.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Abhishek Goel <huntbag@linux.vnet.ibm.com>
Subject: [PATCH] cpupower : Fix cpupower working when cpu0 is offline
Date: Fri, 22 Sep 2017 14:17:32 +0530 [thread overview]
Message-ID: <20170922084732.119903-1-huntbag@linux.vnet.ibm.com> (raw)
cpuidle_monitor used to assume that cpu0 is always online. Now the
cpuidle_monitor function searches for the first online cpu and use
it, instead of always using cpu0 which maynot be online.
Signed-off-by: Abhishek Goel <huntbag@linux.vnet.ibm.com>
---
tools/power/cpupower/utils/idle_monitor/cpuidle_sysfs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/power/cpupower/utils/idle_monitor/cpuidle_sysfs.c b/tools/power/cpupower/utils/idle_monitor/cpuidle_sysfs.c
index 055a4fa..1cfba02 100644
--- a/tools/power/cpupower/utils/idle_monitor/cpuidle_sysfs.c
+++ b/tools/power/cpupower/utils/idle_monitor/cpuidle_sysfs.c
@@ -132,13 +132,13 @@ static struct cpuidle_monitor *cpuidle_register(void)
char *tmp;
int first_online_cpu;
- for (num = 0; num < cpu_count; num++){
+ for (num = 0; num < cpu_count; num++) {
if (cpupower_is_cpu_online(num))
break;
};
first_online_cpu = num;
-
- /* Assume idle state count is the same for all CPUs */
+
+ /* Assume idle state count is the same for all CPUs */
cpuidle_sysfs_monitor.hw_states_num = cpuidle_state_count(first_online_cpu);
if (cpuidle_sysfs_monitor.hw_states_num <= 0)
--
2.9.3
next reply other threads:[~2017-09-22 8:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 8:47 Abhishek Goel [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-09-22 11:02 [PATCH] cpupower : Fix cpupower working when cpu0 is offline Abhishek Goel
2017-09-26 10:12 ` Gautham R Shenoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170922084732.119903-1-huntbag@linux.vnet.ibm.com \
--to=huntbag@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=trenn@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).