From: Viresh Kumar <viresh.kumar@linaro.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
Kevin Hilman <khilman@kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Stephen Boyd <sboyd@codeaurora.org>, Nishanth Menon <nm@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Lina Iyer <lina.iyer@linaro.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
Sudeep Holla <sudeep.holla@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>
Subject: Re: [PATCH V10 0/3] PM / Domains: Performance state support
Date: Wed, 4 Oct 2017 12:15:21 +0530 [thread overview]
Message-ID: <20171004064521.GA3002@vireshk-i7> (raw)
In-Reply-To: <CAPDyKFoG7MovwoSfagw-CTo7WBGcQGjHgNtornNKGXNJ_AxLag@mail.gmail.com>
On 03-10-17, 09:52, Ulf Hansson wrote:
> We sorted out things at LPC!
>
> However, the last weeks discussions at Linaro connect, raised a couple
> of more concerns with the current approach. Let me summarize them
> here.
>
> 1)
> The ->dev_get_performance_state(), which currently translates
> frequency for a device to a performance index of its PM domain, is too
> closely integrated with genpd. Instead this kind of translation rather
> belongs as a part of the OPP core, because of not limiting this only
> to translate frequencies, but perhaps *later* also voltages.
>
> 2)
> Propagating an aggregated increased requested performance state index
> for a genpd, upwards in the hierarchy of its master domains, is
> currently not needed by any existing SoCs.
>
> 3) If some day the need for 2) becomes required, we must not assume a
> 1 to 1 mapping of the supported performance state index for a
> master/subdomain. For example a domain may support 1-5, while its
> master may support 1-8.
>
> Taking this into consideration, this series need yet another round of
> re-spin. The ->dev_get_performance_state() part should be move to the
> OPP layer and the code dealing with the aggregation of the performance
> state index can be greatly simplified.
Thanks for the summary.
>From the above, it looks like I can send this series right away instead of
waiting for the multiple genpd per device thing? Is that the case ?
--
viresh
next prev parent reply other threads:[~2017-10-04 6:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 22:32 [PATCH V10 0/3] PM / Domains: Performance state support Viresh Kumar
2017-09-19 22:32 ` [PATCH V10 1/7] PM / Domains: Add support to select performance-state of domains Viresh Kumar
2017-09-19 22:32 ` [PATCH V10 2/7] PM / OPP: Support updating performance state of device's power domains Viresh Kumar
2017-09-19 22:32 ` [PATCH V10 3/7] PM / Domains: Catch missing genpd_set_performance_state() in masters Viresh Kumar
2017-09-19 22:32 ` [PATCH V10 4/7] soc: qcom: rpmpd: Add a powerdomain driver to model cx/mx powerdomains Viresh Kumar
2017-09-19 22:32 ` [PATCH V10 5/7] soc: qcom: rpmpd: Add support for get/set performance state Viresh Kumar
2017-09-19 22:32 ` [PATCH V10 6/7] mmc: sdhci-msm: Adapt the driver to use OPPs to set clocks/performance state Viresh Kumar
2017-09-19 22:32 ` [PATCH V10 7/7] remoteproc: qcom: q6v5: Vote for proxy powerdomain performance state Viresh Kumar
2017-10-03 7:52 ` [PATCH V10 0/3] PM / Domains: Performance state support Ulf Hansson
2017-10-04 6:45 ` Viresh Kumar [this message]
2017-10-04 7:54 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171004064521.GA3002@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=khilman@kernel.org \
--cc=len.brown@intel.com \
--cc=lina.iyer@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=sudeep.holla@arm.com \
--cc=ulf.hansson@linaro.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).