* [PATCH] PM / OPP: Add missing of_node_put(np)
@ 2017-10-04 6:05 Viresh Kumar
2017-10-04 16:42 ` Stephen Boyd
0 siblings, 1 reply; 3+ messages in thread
From: Viresh Kumar @ 2017-10-04 6:05 UTC (permalink / raw)
To: Viresh Kumar, Nishanth Menon, Stephen Boyd
Cc: Viresh Kumar, linux-pm, Tobias Jordan, 4 . 3+, linux-kernel
From: Tobias Jordan <Tobias.Jordan@elektrobit.com>
The for_each_available_child_of_node() loop in _of_add_opp_table_v2()
doesn't drop the reference to "np" on errors. Fix that.
Fixes: 274659029c9d ("PM / OPP: Add support to parse "operating-points-v2" bindings")
Cc: 4.3+ <stable@vger.kernel.org> # 4.3+
Signed-off-by: Tobias Jordan <Tobias.Jordan@elektrobit.com>
[ VK: Improved commit log. ]
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/opp/of.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/opp/of.c b/drivers/opp/of.c
index 0b718886479b..87509cb69f79 100644
--- a/drivers/opp/of.c
+++ b/drivers/opp/of.c
@@ -397,6 +397,7 @@ static int _of_add_opp_table_v2(struct device *dev, struct device_node *opp_np)
dev_err(dev, "%s: Failed to add OPP, %d\n", __func__,
ret);
_dev_pm_opp_remove_table(opp_table, dev, false);
+ of_node_put(np);
goto put_opp_table;
}
}
--
2.14.1.202.g24db08a6e8fe
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] PM / OPP: Add missing of_node_put(np)
2017-10-04 6:05 [PATCH] PM / OPP: Add missing of_node_put(np) Viresh Kumar
@ 2017-10-04 16:42 ` Stephen Boyd
2017-10-05 4:43 ` Viresh Kumar
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Boyd @ 2017-10-04 16:42 UTC (permalink / raw)
To: Viresh Kumar, Viresh Kumar, Nishanth Menon
Cc: linux-pm, Tobias Jordan, 4 . 3+, linux-kernel
On 10/03/2017 11:05 PM, Viresh Kumar wrote:
> From: Tobias Jordan <Tobias.Jordan@elektrobit.com>
>
> The for_each_available_child_of_node() loop in _of_add_opp_table_v2()
> doesn't drop the reference to "np" on errors. Fix that.
>
> Fixes: 274659029c9d ("PM / OPP: Add support to parse "operating-points-v2" bindings")
> Cc: 4.3+ <stable@vger.kernel.org> # 4.3+
> Signed-off-by: Tobias Jordan <Tobias.Jordan@elektrobit.com>
> [ VK: Improved commit log. ]
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
Looks like that opp_table->np = opp_np assignment in this function needs
to do an of_node_get() because the caller of this function puts the
pointer unconditionally.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PM / OPP: Add missing of_node_put(np)
2017-10-04 16:42 ` Stephen Boyd
@ 2017-10-05 4:43 ` Viresh Kumar
0 siblings, 0 replies; 3+ messages in thread
From: Viresh Kumar @ 2017-10-05 4:43 UTC (permalink / raw)
To: Stephen Boyd
Cc: Viresh Kumar, Nishanth Menon, linux-pm, Tobias Jordan, 4 . 3+,
linux-kernel
On 04-10-17, 09:42, Stephen Boyd wrote:
> On 10/03/2017 11:05 PM, Viresh Kumar wrote:
> > From: Tobias Jordan <Tobias.Jordan@elektrobit.com>
> >
> > The for_each_available_child_of_node() loop in _of_add_opp_table_v2()
> > doesn't drop the reference to "np" on errors. Fix that.
> >
> > Fixes: 274659029c9d ("PM / OPP: Add support to parse "operating-points-v2" bindings")
> > Cc: 4.3+ <stable@vger.kernel.org> # 4.3+
> > Signed-off-by: Tobias Jordan <Tobias.Jordan@elektrobit.com>
> > [ VK: Improved commit log. ]
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > ---
>
> Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
>
> Looks like that opp_table->np = opp_np assignment in this function needs
> to do an of_node_get() because the caller of this function puts the
> pointer unconditionally.
We only use that pointer (opp_table->np) in _managed_opp() to compare the
address. Perhaps we don't need to do a of_node_get() there.
--
viresh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-05 4:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-04 6:05 [PATCH] PM / OPP: Add missing of_node_put(np) Viresh Kumar
2017-10-04 16:42 ` Stephen Boyd
2017-10-05 4:43 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).