* [PATCH] PM / ACPI: Removed unused function
@ 2017-10-06 7:08 Ulf Hansson
2017-10-06 12:12 ` Pavel Machek
2017-10-10 16:55 ` Rafael J. Wysocki
0 siblings, 2 replies; 5+ messages in thread
From: Ulf Hansson @ 2017-10-06 7:08 UTC (permalink / raw)
To: Rafael J . Wysocki, linux-acpi, linux-pm
Cc: Len Brown, Pavel Machek, Ulf Hansson
acpi_dev_pm_get_node() isn't used or implemented, let's remove it.
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
include/linux/acpi.h | 5 -----
1 file changed, 5 deletions(-)
diff --git a/include/linux/acpi.h b/include/linux/acpi.h
index 502af53..3b89b4f 100644
--- a/include/linux/acpi.h
+++ b/include/linux/acpi.h
@@ -868,17 +868,12 @@ int acpi_dev_runtime_suspend(struct device *dev);
int acpi_dev_runtime_resume(struct device *dev);
int acpi_subsys_runtime_suspend(struct device *dev);
int acpi_subsys_runtime_resume(struct device *dev);
-struct acpi_device *acpi_dev_pm_get_node(struct device *dev);
int acpi_dev_pm_attach(struct device *dev, bool power_on);
#else
static inline int acpi_dev_runtime_suspend(struct device *dev) { return 0; }
static inline int acpi_dev_runtime_resume(struct device *dev) { return 0; }
static inline int acpi_subsys_runtime_suspend(struct device *dev) { return 0; }
static inline int acpi_subsys_runtime_resume(struct device *dev) { return 0; }
-static inline struct acpi_device *acpi_dev_pm_get_node(struct device *dev)
-{
- return NULL;
-}
static inline int acpi_dev_pm_attach(struct device *dev, bool power_on)
{
return -ENODEV;
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] PM / ACPI: Removed unused function
2017-10-06 7:08 [PATCH] PM / ACPI: Removed unused function Ulf Hansson
@ 2017-10-06 12:12 ` Pavel Machek
2017-10-06 12:14 ` Pavel Machek
2017-10-10 16:55 ` Rafael J. Wysocki
1 sibling, 1 reply; 5+ messages in thread
From: Pavel Machek @ 2017-10-06 12:12 UTC (permalink / raw)
To: Ulf Hansson; +Cc: Rafael J . Wysocki, linux-acpi, linux-pm, Len Brown
[-- Attachment #1: Type: text/plain, Size: 359 bytes --]
On Fri 2017-10-06 09:08:34, Ulf Hansson wrote:
> acpi_dev_pm_get_node() isn't used or implemented, let's remove it.
>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] PM / ACPI: Removed unused function
2017-10-06 12:12 ` Pavel Machek
@ 2017-10-06 12:14 ` Pavel Machek
2017-10-07 6:44 ` Ulf Hansson
0 siblings, 1 reply; 5+ messages in thread
From: Pavel Machek @ 2017-10-06 12:14 UTC (permalink / raw)
To: Ulf Hansson; +Cc: Rafael J . Wysocki, linux-acpi, linux-pm, Len Brown
[-- Attachment #1: Type: text/plain, Size: 917 bytes --]
On Fri 2017-10-06 14:12:30, Pavel Machek wrote:
> On Fri 2017-10-06 09:08:34, Ulf Hansson wrote:
> > acpi_dev_pm_get_node() isn't used or implemented, let's remove it.
> >
> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
>
> Acked-by: Pavel Machek <pavel@ucw.cz>
I was too quick sending this.
How is it unused?
./drivers/acpi/device_pm.c: * acpi_dev_pm_attach - Prepare device for
ACPI power management.
./drivers/acpi/device_pm.c:int acpi_dev_pm_attach(struct device *dev,
bool power_on)
./drivers/acpi/device_pm.c:EXPORT_SYMBOL_GPL(acpi_dev_pm_attach);
Binary file ./drivers/acpi/device_pm.o matches
Binary file ./drivers/base/power/common.o matches
./drivers/base/power/common.c: ret =
acpi_dev_pm_attach(dev, power_on);
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] PM / ACPI: Removed unused function
2017-10-06 12:14 ` Pavel Machek
@ 2017-10-07 6:44 ` Ulf Hansson
0 siblings, 0 replies; 5+ messages in thread
From: Ulf Hansson @ 2017-10-07 6:44 UTC (permalink / raw)
To: Pavel Machek
Cc: Rafael J . Wysocki, ACPI Devel Maling List,
linux-pm@vger.kernel.org, Len Brown
On 6 October 2017 at 14:14, Pavel Machek <pavel@ucw.cz> wrote:
> On Fri 2017-10-06 14:12:30, Pavel Machek wrote:
>> On Fri 2017-10-06 09:08:34, Ulf Hansson wrote:
>> > acpi_dev_pm_get_node() isn't used or implemented, let's remove it.
>> >
>> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
>>
>> Acked-by: Pavel Machek <pavel@ucw.cz>
>
> I was too quick sending this.
>
> How is it unused?
>
> ./drivers/acpi/device_pm.c: * acpi_dev_pm_attach - Prepare device for
> ACPI power management.
> ./drivers/acpi/device_pm.c:int acpi_dev_pm_attach(struct device *dev,
> bool power_on)
> ./drivers/acpi/device_pm.c:EXPORT_SYMBOL_GPL(acpi_dev_pm_attach);
> Binary file ./drivers/acpi/device_pm.o matches
> Binary file ./drivers/base/power/common.o matches
> ./drivers/base/power/common.c: ret =
> acpi_dev_pm_attach(dev, power_on);
I think you searched for the wrong function. It should be
acpi_dev_pm_get_node().
Kind regards
Uffe
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] PM / ACPI: Removed unused function
2017-10-06 7:08 [PATCH] PM / ACPI: Removed unused function Ulf Hansson
2017-10-06 12:12 ` Pavel Machek
@ 2017-10-10 16:55 ` Rafael J. Wysocki
1 sibling, 0 replies; 5+ messages in thread
From: Rafael J. Wysocki @ 2017-10-10 16:55 UTC (permalink / raw)
To: Ulf Hansson; +Cc: linux-acpi, linux-pm, Len Brown, Pavel Machek
On Friday, October 6, 2017 9:08:34 AM CEST Ulf Hansson wrote:
> acpi_dev_pm_get_node() isn't used or implemented, let's remove it.
>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
> include/linux/acpi.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/include/linux/acpi.h b/include/linux/acpi.h
> index 502af53..3b89b4f 100644
> --- a/include/linux/acpi.h
> +++ b/include/linux/acpi.h
> @@ -868,17 +868,12 @@ int acpi_dev_runtime_suspend(struct device *dev);
> int acpi_dev_runtime_resume(struct device *dev);
> int acpi_subsys_runtime_suspend(struct device *dev);
> int acpi_subsys_runtime_resume(struct device *dev);
> -struct acpi_device *acpi_dev_pm_get_node(struct device *dev);
> int acpi_dev_pm_attach(struct device *dev, bool power_on);
> #else
> static inline int acpi_dev_runtime_suspend(struct device *dev) { return 0; }
> static inline int acpi_dev_runtime_resume(struct device *dev) { return 0; }
> static inline int acpi_subsys_runtime_suspend(struct device *dev) { return 0; }
> static inline int acpi_subsys_runtime_resume(struct device *dev) { return 0; }
> -static inline struct acpi_device *acpi_dev_pm_get_node(struct device *dev)
> -{
> - return NULL;
> -}
> static inline int acpi_dev_pm_attach(struct device *dev, bool power_on)
> {
> return -ENODEV;
>
Applied, thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-10-10 17:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-06 7:08 [PATCH] PM / ACPI: Removed unused function Ulf Hansson
2017-10-06 12:12 ` Pavel Machek
2017-10-06 12:14 ` Pavel Machek
2017-10-07 6:44 ` Ulf Hansson
2017-10-10 16:55 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).