From: Viresh Kumar <viresh.kumar@linaro.org>
To: Jesper Nilsson <jesper.nilsson@axis.com>
Cc: "rjw@sisk.pl" <rjw@sisk.pl>,
"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
"patches@linaro.org" <patches@linaro.org>,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Jesper Nilsson <jespern@axis.com>,
Mikael Starvik <starvik@axis.com>,
linux-cris-kernel <linux-cris-kernel@axis.com>
Subject: Re: [PATCH 07/34] cpufreq: cris: remove calls to cpufreq_notify_transition()
Date: Tue, 10 Oct 2017 14:43:01 +0530 [thread overview]
Message-ID: <20171010091301.GH4031@vireshk-i7> (raw)
In-Reply-To: <20171010075742.GL17578@axis.com>
On 10-10-17, 09:57, Jesper Nilsson wrote:
> On Fri, Aug 16, 2013 at 04:25:04AM +0200, Viresh Kumar wrote:
> > Most of the drivers do following in their ->target_index() routines:
> >
> > struct cpufreq_freqs freqs;
> > freqs.old = old freq...
> > freqs.new = new freq...
> >
> > cpufreq_notify_transition(policy, &freqs, CPUFREQ_PRECHANGE);
> >
> > /* Change rate here */
> >
> > cpufreq_notify_transition(policy, &freqs, CPUFREQ_POSTCHANGE);
> >
> > This is replicated over all cpufreq drivers today and there doesn't exists a
> > good enough reason why this shouldn't be moved to cpufreq core instead.
> >
> > Earlier patches have added support in cpufreq core to do cpufreq notification on
> > frequency change, this one removes it from this driver.
> >
> > Some related minor cleanups are also done along with it.
> >
>
> Acked-by: Jesper Nilsson <jesper.nilsson@axis.com>
Wow..
You just Acked a 4 years old patch :)
--
viresh
next prev parent reply other threads:[~2017-10-10 9:13 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-16 2:24 [PATCH 00/34] CPUFreq: Move freq change notifications out of drivers Viresh Kumar
2013-08-16 2:24 ` [PATCH 01/34] cpufreq: move freq change notifications to cpufreq core Viresh Kumar
2013-08-16 2:24 ` [PATCH 02/34] cpufreq: acpi: remove calls to cpufreq_notify_transition() Viresh Kumar
[not found] ` <CAOLK0pz7e8nQVnZY0a-j_Fd_kFOqF8ZS4tRfYw1S+25Lv8GoFQ@mail.gmail.com>
[not found] ` <CAOLK0pyVDSc6x1u8Ro6ng1dH8ELqc3P9jPHamgiXBn6sWDgm8w@mail.gmail.com>
2013-08-16 7:59 ` Viresh Kumar
2013-08-16 15:30 ` Lan Tianyu
2013-08-16 2:25 ` [PATCH 03/34] cpufreq: arm_big_little: " Viresh Kumar
2013-08-16 2:25 ` [PATCH 04/34] cpufreq: at32ap: " Viresh Kumar
2013-08-16 5:58 ` Hans-Christian Egtvedt
2013-08-16 2:25 ` [PATCH 05/34] cpufreq: blackfin: " Viresh Kumar
2013-08-16 2:25 ` [PATCH 06/34] cpufreq: cpu0: " Viresh Kumar
2013-08-16 2:25 ` [PATCH 07/34] cpufreq: cris: " Viresh Kumar
2017-10-10 7:57 ` Jesper Nilsson
2017-10-10 9:13 ` Viresh Kumar [this message]
2013-08-16 2:25 ` [PATCH 08/34] cpufreq: davinci: " Viresh Kumar
2013-08-16 2:25 ` [PATCH 09/34] cpufreq: dbx500: " Viresh Kumar
2013-08-16 2:25 ` [PATCH 10/34] cpufreq: e_powersaver: " Viresh Kumar
2013-08-16 2:25 ` [PATCH 11/34] cpufreq: elanfreq: " Viresh Kumar
2013-08-16 2:25 ` [PATCH 12/34] cpufreq: exynos: " Viresh Kumar
2013-08-16 2:25 ` [PATCH 13/34] cpufreq: exynos5440: set CPUFREQ_NO_NOTIFICATION flag Viresh Kumar
2013-08-18 10:54 ` amit daniel kachhap
2013-08-18 21:57 ` Kukjin Kim
2013-08-19 3:42 ` amit daniel kachhap
2013-08-19 4:40 ` Viresh Kumar
2013-08-16 2:25 ` [PATCH 14/34] cpufreq: ia64-acpi: remove calls to cpufreq_notify_transition() Viresh Kumar
2013-08-16 2:25 ` [PATCH 15/34] cpufreq: imx6q: " Viresh Kumar
2013-08-16 2:25 ` [PATCH 16/34] cpufreq: kirkwood: " Viresh Kumar
2013-08-16 2:25 ` [PATCH 17/34] cpufreq: longhaul: set CPUFREQ_NO_NOTIFICATION flag Viresh Kumar
2013-08-16 2:25 ` [PATCH 18/34] cpufreq: loongson2: remove calls to cpufreq_notify_transition() Viresh Kumar
2013-08-16 2:25 ` [PATCH 19/34] cpufreq: maple: " Viresh Kumar
2013-08-16 2:25 ` [PATCH 20/34] cpufreq: omap: " Viresh Kumar
2013-08-16 2:25 ` [PATCH 21/34] cpufreq: p4-clockmod: " Viresh Kumar
2013-08-16 2:25 ` [PATCH 22/34] cpufreq: pasemi: " Viresh Kumar
2013-08-16 2:25 ` [PATCH 23/34] cpufreq: pmac: " Viresh Kumar
2013-08-16 2:25 ` [PATCH 24/34] cpufreq: powernow: " Viresh Kumar
2013-08-16 2:25 ` [PATCH 25/34] cpufreq: ppc: " Viresh Kumar
2013-08-16 2:25 ` [PATCH 26/34] cpufreq: pxa: " Viresh Kumar
2013-08-16 2:25 ` [PATCH 27/34] cpufreq: s3c: " Viresh Kumar
2013-08-16 2:25 ` [PATCH 28/34] cpufreq: s5pv210: " Viresh Kumar
2013-08-16 2:25 ` [PATCH 29/34] cpufreq: sa11x0: " Viresh Kumar
2013-08-16 2:25 ` [PATCH 30/34] cpufreq: sc520: " Viresh Kumar
2013-08-16 2:25 ` [PATCH 31/34] cpufreq: sparc: " Viresh Kumar
2013-08-16 2:25 ` [PATCH 32/34] cpufreq: SPEAr: " Viresh Kumar
2013-08-16 2:25 ` [PATCH 33/34] cpufreq: speedstep: " Viresh Kumar
2013-08-16 2:25 ` [PATCH 34/34] cpufreq: tegra: " Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171010091301.GH4031@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=cpufreq@vger.kernel.org \
--cc=jesper.nilsson@axis.com \
--cc=jespern@axis.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-cris-kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=patches@linaro.org \
--cc=rjw@sisk.pl \
--cc=starvik@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).