Re: [PATCH v2] PM / OPP: add missing of_node_put() for of_get_cpu_node()

[Viresh Kumar <viresh.kumar@linaro.org>]

On 11-10-17, 11:11, Sudeep Holla wrote:
> Commit 762792913f8c ("PM / OPP: Fix get sharing CPUs when hotplug is used")
> moved away from using cpu_dev->of_node because of some limitations.
> However commit 7467c9d95989 ("of: return of_get_cpu_node from
> of_cpu_device_node_get if CPUs are not registered") added support to
> falls back to of_get_cpu_node if called if CPUs are not registered yet.
> 
> It adds the missing of_node_put for the CPU device nodes. This patch also
> moves back to use of_cpu_device_node_get in dev_pm_opp_of_get_sharing_cpus
> to avoid scanning the device tree again.
> 
> Cc: Viresh Kumar <vireshk@kernel.org>
> Cc: Nishanth Menon <nm@ti.com>
> Cc: Stephen Boyd <sboyd@codeaurora.org>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Fixes: 762792913f8c ("PM / OPP: Fix get sharing CPUs when hotplug is used")
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>

Cc: 4.14+ <stable@vger.kernel.org> # 4.14+

> ---
>  drivers/opp/of.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> v1->v2:
> 	- Moved of_node_put after using cpu_np
> 	- Renamed the $subject as fixing refcount is key part of the part
> 	  and correctly relates to "Fixes" tag
> 	- Also added include change which was accidentally missed

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh