From: Steven Rostedt <rostedt@goodmis.org>
To: Jean Pihet <jean.pihet@newoldbits.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
discuss@lesswatts.org, Linux PM list <linux-pm@vger.kernel.org>,
Thomas Renninger <trenn@suse.de>,
Arjan van de Ven <arjan@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Len Brown <len.brown@intel.com>,
Kevin Hilman <khilman@deeprootsystems.com>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] tracing: Remove unused clock events
Date: Fri, 13 Oct 2017 10:25:53 -0400 [thread overview]
Message-ID: <20171013102553.4e954f27@gandalf.local.home> (raw)
In-Reply-To: <CAORVsuU+12OEH4LFePORWHh3Ryfj-2cc8Kb6U-dQo4HQUXSJAA@mail.gmail.com>
On Fri, 13 Oct 2017 09:20:44 +0200
Jean Pihet <jean.pihet@newoldbits.com> wrote:
> Hi Steven,
>
> On Thu, Oct 12, 2017 at 6:44 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > [ Resending again, including linux-pm@vger.kernel.org this time ]
> >
> > From: Steven Rostedt (VMware) <rostedt@goodmis.org>
> >
> > Commit 74704ac6 ("tracing, perf: Add more power related events") added
> > new events, among them were trace_clock_enable, trace_clock_disable and
> > trace_clock_set_rate. In the last 7 years, nothing has used them. As
> > they take up space, and nobody cares about these events, remove them.
>
> Ok if it is not used. Can others confirm?
>
> AFAIK this has been used internally.
If it has been used internally, then the events should be defined
internally. The trace event hooks are not there, there's no reason to
define events were hooks are not present. There's no advantage for
keeping them in the kernel proper.
-- Steve
prev parent reply other threads:[~2017-10-13 14:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 16:44 [PATCH] tracing: Remove unused clock events Steven Rostedt
2017-10-13 7:20 ` Jean Pihet
2017-10-13 14:25 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171013102553.4e954f27@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=arjan@linux.intel.com \
--cc=discuss@lesswatts.org \
--cc=jean.pihet@newoldbits.com \
--cc=khilman@deeprootsystems.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox