From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eduardo Valentin Subject: Re: [PATCH 01/25] thermal/drivers/hisi: Fix missing interrupt enablement Date: Mon, 16 Oct 2017 14:50:20 -0700 Message-ID: <20171016215019.GA4292@localhost.localdomain> References: <79a5f10c-0fb7-3e4f-caac-c1625904b137@linaro.org> <1507658570-32675-1-git-send-email-daniel.lezcano@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1507658570-32675-1-git-send-email-daniel.lezcano@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: Daniel Lezcano Cc: rui.zhang@intel.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, kevin.wangtao@linaro.org, Leo Yan List-Id: linux-pm@vger.kernel.org On Tue, Oct 10, 2017 at 08:02:26PM +0200, Daniel Lezcano wrote: > The interrupt for the temperature threshold is not enabled at the end of the > probe function, enable it after the setup is complete. > > On the other side, the irq_enabled is not correctly set as we are checking if > the interrupt is masked where 'yes' means irq_enabled=false. > > irq_get_irqchip_state(data->irq, IRQCHIP_STATE_MASKED, > &data->irq_enabled); > > As we are always enabling the interrupt, it is pointless to check if > the interrupt is masked or not, just set irq_enabled to 'true'. If no objections, I will start collecting this series. > > Signed-off-by: Daniel Lezcano > Reviewed-by: Leo Yan > Tested-by: Leo Yan > --- > drivers/thermal/hisi_thermal.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/thermal/hisi_thermal.c b/drivers/thermal/hisi_thermal.c > index 9c3ce34..f3b50b0 100644 > --- a/drivers/thermal/hisi_thermal.c > +++ b/drivers/thermal/hisi_thermal.c > @@ -345,8 +345,7 @@ static int hisi_thermal_probe(struct platform_device *pdev) > } > > hisi_thermal_enable_bind_irq_sensor(data); > - irq_get_irqchip_state(data->irq, IRQCHIP_STATE_MASKED, > - &data->irq_enabled); > + data->irq_enabled = true; > > for (i = 0; i < HISI_MAX_SENSORS; ++i) { > ret = hisi_thermal_register_sensor(pdev, data, > @@ -358,6 +357,8 @@ static int hisi_thermal_probe(struct platform_device *pdev) > hisi_thermal_toggle_sensor(&data->sensors[i], true); > } > > + enable_irq(data->irq); > + > return 0; > } > > -- > 2.7.4 >