* [PATCH] freezer: Fix typo in commnent to function freezable_schedule_timeout()
@ 2017-11-04 21:57 Himanshu Jha
2017-11-04 22:02 ` Pavel Machek
2017-11-07 19:52 ` Luis R. Rodriguez
0 siblings, 2 replies; 5+ messages in thread
From: Himanshu Jha @ 2017-11-04 21:57 UTC (permalink / raw)
To: rjw; +Cc: pavel, len.brown, linux-pm, linux-kernel, mcgrof, Himanshu Jha
Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
---
include/linux/freezer.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/freezer.h b/include/linux/freezer.h
index 3995df1..21f5aa0 100644
--- a/include/linux/freezer.h
+++ b/include/linux/freezer.h
@@ -182,7 +182,7 @@ static inline void freezable_schedule_unsafe(void)
}
/*
- * Like freezable_schedule_timeout(), but should not block the freezer. Do not
+ * Like schedule_timeout(), but should not block the freezer. Do not
* call this with locks held.
*/
static inline long freezable_schedule_timeout(long timeout)
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] freezer: Fix typo in commnent to function freezable_schedule_timeout()
2017-11-04 21:57 [PATCH] freezer: Fix typo in commnent to function freezable_schedule_timeout() Himanshu Jha
@ 2017-11-04 22:02 ` Pavel Machek
2017-11-06 11:27 ` Himanshu Jha
2017-11-07 19:52 ` Luis R. Rodriguez
1 sibling, 1 reply; 5+ messages in thread
From: Pavel Machek @ 2017-11-04 22:02 UTC (permalink / raw)
To: Himanshu Jha; +Cc: rjw, len.brown, linux-pm, linux-kernel, mcgrof
[-- Attachment #1: Type: text/plain, Size: 896 bytes --]
On Sun 2017-11-05 03:27:32, Himanshu Jha wrote:
> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
ACK.
But note you have typo in the subject ;-).
Plus this kind of bug is usually called thinko.
Pavel
> diff --git a/include/linux/freezer.h b/include/linux/freezer.h
> index 3995df1..21f5aa0 100644
> --- a/include/linux/freezer.h
> +++ b/include/linux/freezer.h
> @@ -182,7 +182,7 @@ static inline void freezable_schedule_unsafe(void)
> }
>
> /*
> - * Like freezable_schedule_timeout(), but should not block the freezer. Do not
> + * Like schedule_timeout(), but should not block the freezer. Do not
> * call this with locks held.
> */
> static inline long freezable_schedule_timeout(long timeout)
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] freezer: Fix typo in commnent to function freezable_schedule_timeout()
2017-11-04 22:02 ` Pavel Machek
@ 2017-11-06 11:27 ` Himanshu Jha
2017-11-06 11:38 ` Pavel Machek
0 siblings, 1 reply; 5+ messages in thread
From: Himanshu Jha @ 2017-11-06 11:27 UTC (permalink / raw)
To: Pavel Machek; +Cc: rjw, len.brown, linux-pm, linux-kernel, mcgrof
On Sat, Nov 04, 2017 at 11:02:56PM +0100, Pavel Machek wrote:
> On Sun 2017-11-05 03:27:32, Himanshu Jha wrote:
> > Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
>
> ACK.
>
> But note you have typo in the subject ;-).
Oops!
Do I need to send v2 with correct subject ?
> Plus this kind of bug is usually called thinko.
> Pavel
>
>
> > diff --git a/include/linux/freezer.h b/include/linux/freezer.h
> > index 3995df1..21f5aa0 100644
> > --- a/include/linux/freezer.h
> > +++ b/include/linux/freezer.h
> > @@ -182,7 +182,7 @@ static inline void freezable_schedule_unsafe(void)
> > }
> >
> > /*
> > - * Like freezable_schedule_timeout(), but should not block the freezer. Do not
> > + * Like schedule_timeout(), but should not block the freezer. Do not
> > * call this with locks held.
> > */
> > static inline long freezable_schedule_timeout(long timeout)
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Thanks
Himanshu Jha
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] freezer: Fix typo in commnent to function freezable_schedule_timeout()
2017-11-06 11:27 ` Himanshu Jha
@ 2017-11-06 11:38 ` Pavel Machek
0 siblings, 0 replies; 5+ messages in thread
From: Pavel Machek @ 2017-11-06 11:38 UTC (permalink / raw)
To: Himanshu Jha; +Cc: rjw, len.brown, linux-pm, linux-kernel, mcgrof
[-- Attachment #1: Type: text/plain, Size: 1456 bytes --]
On Mon 2017-11-06 16:57:09, Himanshu Jha wrote:
> On Sat, Nov 04, 2017 at 11:02:56PM +0100, Pavel Machek wrote:
> > On Sun 2017-11-05 03:27:32, Himanshu Jha wrote:
> > > Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
> >
> > ACK.
> >
> > But note you have typo in the subject ;-).
>
> Oops!
> Do I need to send v2 with correct subject ?
I don't think that's required. I expect rjw will pick it up, maybe
fixing the subject.
Pavel
> > Plus this kind of bug is usually called thinko.
> > Pavel
> >
> >
> > > diff --git a/include/linux/freezer.h b/include/linux/freezer.h
> > > index 3995df1..21f5aa0 100644
> > > --- a/include/linux/freezer.h
> > > +++ b/include/linux/freezer.h
> > > @@ -182,7 +182,7 @@ static inline void freezable_schedule_unsafe(void)
> > > }
> > >
> > > /*
> > > - * Like freezable_schedule_timeout(), but should not block the freezer. Do not
> > > + * Like schedule_timeout(), but should not block the freezer. Do not
> > > * call this with locks held.
> > > */
> > > static inline long freezable_schedule_timeout(long timeout)
> >
> > --
> > (english) http://www.livejournal.com/~pavelmachek
> > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
>
> Thanks
> Himanshu Jha
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] freezer: Fix typo in commnent to function freezable_schedule_timeout()
2017-11-04 21:57 [PATCH] freezer: Fix typo in commnent to function freezable_schedule_timeout() Himanshu Jha
2017-11-04 22:02 ` Pavel Machek
@ 2017-11-07 19:52 ` Luis R. Rodriguez
1 sibling, 0 replies; 5+ messages in thread
From: Luis R. Rodriguez @ 2017-11-07 19:52 UTC (permalink / raw)
To: Himanshu Jha; +Cc: rjw, pavel, len.brown, linux-pm, linux-kernel, mcgrof
On Sun, Nov 05, 2017 at 03:27:32AM +0530, Himanshu Jha wrote:
> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
FWIW,
Suggested-by: Luis R. Rodriguez <mcgrof@kernel.org>
Acked-by: Luis R. Rodriguez <mcgrof@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-11-07 19:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-04 21:57 [PATCH] freezer: Fix typo in commnent to function freezable_schedule_timeout() Himanshu Jha
2017-11-04 22:02 ` Pavel Machek
2017-11-06 11:27 ` Himanshu Jha
2017-11-06 11:38 ` Pavel Machek
2017-11-07 19:52 ` Luis R. Rodriguez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).