From: Tony Lindgren <tony@atomide.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
linux-gpio@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
ckeepax@opensource.wolfsonmicro.com, swarren@nvidia.com,
andy.shevchenko@gmail.com, alcooperx@gmail.com,
bcm-kernel-feedback-list@broadcom.com, linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 0/2] pinctrl: Allow indicating loss of state across suspend/resume
Date: Tue, 7 Nov 2017 17:02:22 -0800 [thread overview]
Message-ID: <20171108010222.GS28152@atomide.com> (raw)
In-Reply-To: <4931157.VlYOOLbas7@aspire.rjw.lan>
* Rafael J. Wysocki <rjw@rjwysocki.net> [171108 00:25]:
> On Tuesday, November 7, 2017 5:00:06 PM CET Tony Lindgren wrote:
> > For runtime PM, restoring the state constantly is unnecessary and not
> > good for battery life. The logic can be just:
> >
> > 1. Device driver runtime PM suspend saves the state when needed
> >
> > 2. Device driver runtime PM resume checks if context_lost was set by
> > the bus or power domain code
> >
> > 3. If context was lost, device driver restores the state, or in some
> > cases may need re-run the driver register init related parts
> > to bring the driver back up, then clears the context_lost flag
> >
> > How about something like the following patch? So far only compile
> > tested with CONFIG_PM enabled. If that looks like the way to go,
> > I'll test it properly and add some comments for the functions and
> > post a proper patch :)
>
> Honestly, I'm not sure.
>
> I'd rather have a context_lost flag to start with and see how/if
> drivers will use that before adding any common infra for handling
> this.
Right, I'll provide some use cases but it will be a little while.
Currently it's done in non-generic way at the interconnect code
for my use cases:
$ git grep "\.context_offs = " arch/arm/mach-omap2/*data.c | wc -l
276
It seems that we could have genpd take care of this in a generic
way with the patch I posted.
Regards,
Tony
prev parent reply other threads:[~2017-11-08 1:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171102231551.16220-1-f.fainelli@gmail.com>
[not found] ` <20171103103707.3e5wb3c7foxbuvvg@localhost.localdomain>
2017-11-03 16:11 ` [PATCH v2 0/2] pinctrl: Allow indicating loss of state across suspend/resume Tony Lindgren
2017-11-03 17:02 ` Florian Fainelli
2017-11-03 17:33 ` Tony Lindgren
2017-11-04 8:37 ` Charles Keepax
[not found] ` <20171104083707.gtmnhbrzlqjulwe4-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2017-11-07 16:00 ` Tony Lindgren
[not found] ` <20171103173353.GJ28152-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-11-04 12:25 ` Rafael J. Wysocki
2017-11-04 17:19 ` Florian Fainelli
2017-11-07 16:00 ` Tony Lindgren
2017-11-08 0:23 ` Rafael J. Wysocki
2017-11-08 0:28 ` Florian Fainelli
2017-11-08 0:45 ` Rafael J. Wysocki
2017-11-08 1:04 ` Tony Lindgren
2017-11-08 1:02 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171108010222.GS28152@atomide.com \
--to=tony@atomide.com \
--cc=alcooperx@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).