From: Viresh Kumar <viresh.kumar@linaro.org>
To: Bastian Stender <bst@pengutronix.de>, shawnguo@kernel.org
Cc: Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
linux-pm@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] thermal: imx: remove cooling device
Date: Wed, 15 Nov 2017 10:30:32 +0530 [thread overview]
Message-ID: <20171115050032.GH3257@vireshk-i7> (raw)
In-Reply-To: <20171115045626.GF3257@vireshk-i7>
On 15-11-17, 10:26, Viresh Kumar wrote:
> + Shawn
>
> On 14-11-17, 14:48, Bastian Stender wrote:
> > The cooling device should not be part of the i.MX thermal code but
> > rather in the i.MX cpufreq driver. So remove it here.
> >
> > Signed-off-by: Bastian Stender <bst@pengutronix.de>
>
> Shouldn't the two patches you sent be part of a series? What if one gets applied
> before the other? For example if the cpufreq patch gets applied before this one,
> then the kernel would break somewhere as two drivers would be adding the
> cpu-cooling device :)
Actually, we may really want to have a single patch for this. So I would suggest
that we merge both the patches.
--
viresh
next prev parent reply other threads:[~2017-11-15 5:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 13:48 [PATCH] thermal: imx: remove cooling device Bastian Stender
2017-11-15 4:56 ` Viresh Kumar
2017-11-15 5:00 ` Viresh Kumar [this message]
2017-11-15 9:05 ` Bastian Stender
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171115050032.GH3257@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=bst@pengutronix.de \
--cc=edubezval@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).