linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Valentin <edubezval@gmail.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Javi Merino <javi.merino@kernel.org>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Rafael Wysocki <rjw@rjwysocki.net>,
	Amit Daniel Kachhap <amit.kachhap@gmail.com>,
	Zhang Rui <rui.zhang@intel.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ingo Molnar <mingo@redhat.com>,
	linux-pm@vger.kernel.org,
	Vincent Guittot <vincent.guittot@linaro.org>,
	lukasz.luba@arm.com, linux-kernel@vger.kernel.org,
	Punit Agrawal <punit.agrawal@arm.com>
Subject: Re: [PATCH 4/4] cpu_cooling: Drop static-power related stuff
Date: Wed, 15 Nov 2017 07:09:26 -0800	[thread overview]
Message-ID: <20171115150924.GA1758@localhost.localdomain> (raw)
In-Reply-To: <2932a544-dd58-11e3-4012-7d281d6b64ef@linaro.org>

On Wed, Nov 15, 2017 at 12:39:36PM +0100, Daniel Lezcano wrote:
> On 15/11/2017 12:31, Javi Merino wrote:
> > On Wed, Nov 15, 2017 at 02:49:48PM +0530, Viresh Kumar wrote:
> >> No one has used it for the last two and half years (since it was
> >> introduced by commit c36cf0717631 ("thermal: cpu_cooling: implement the
> >> power cooling device API")), get rid of it.
> > 
> > Linaro used it in lsk 3.18 for the cpufreq driver for Juno.  The cpufreq
> > driver was converted to the generic one from dt in lsk 4.4, but the
> > generic cpufreq driver does not support static power because everything
> > has to come from device tree and we don't have a way to specify it there.
> 
> Are in favor of removing it or improving the code ?

Yes, to what I can remember, Juno driver originally used this and it was
supposed to be a reference on who this stuff gets to be used. So, this
is more like "the code never made mainline" instead of no one is using.

And to be frank, this is the API that represents static power, which is
the component that differentiate things while using IPA. Maybe 

So yes, my suggestion is to put effort to get the juno code that uses
the static power back to mainline.

> 
> 
> -- 
>  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
> 
> Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog
> 

  reply	other threads:[~2017-11-15 15:09 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-15  9:19 [PATCH 0/4] cpu_cooling: cooling dev registration cleanups Viresh Kumar
2017-11-15  9:19 ` [PATCH 1/4] cpu_cooling: Make of_cpufreq_power_cooling_register() parse DT Viresh Kumar
2017-11-15  9:19 ` [PATCH 2/4] cpu_cooling: Remove unused cpufreq_power_cooling_register() Viresh Kumar
2017-11-15  9:19 ` [PATCH 3/4] cpu_cooling: Keep only one of_cpufreq*cooling_register() helper Viresh Kumar
2017-11-15  9:19 ` [PATCH 4/4] cpu_cooling: Drop static-power related stuff Viresh Kumar
2017-11-15 10:18   ` Daniel Lezcano
2017-11-15 11:25     ` Viresh Kumar
2017-11-15 15:43     ` Eduardo Valentin
2017-11-15 18:17       ` Rafael J. Wysocki
2017-11-15 18:20         ` Eduardo Valentin
2017-11-16 15:02           ` Ionela Voinescu
2017-11-16 15:20             ` Viresh Kumar
2017-11-16 23:31               ` Rafael J. Wysocki
2017-11-16 23:44                 ` Eduardo Valentin
2017-11-17 11:02                   ` Punit Agrawal
2017-11-17 11:06                     ` Viresh Kumar
2017-11-21 11:30                     ` Ionela Voinescu
2017-11-21 13:06                       ` Daniel Lezcano
2017-11-21 15:56                         ` Lukasz Luba
2017-11-21 16:08                           ` Vincent Guittot
2017-11-21 16:57                             ` Eduardo Valentin
2017-11-21 18:00                               ` Javi Merino
2017-11-21 18:05                                 ` Daniel Lezcano
2017-11-21 18:13                                   ` Eduardo Valentin
2017-11-21 23:32                                     ` Lukasz Luba
2017-11-21 18:12                                 ` Eduardo Valentin
2017-11-22 10:59                                   ` Sudeep Holla
2017-11-22 11:10                                     ` Viresh Kumar
2017-11-22 11:17                                       ` Sudeep Holla
2017-11-22 15:38                                       ` Eduardo Valentin
2017-11-22 15:34                                     ` Eduardo Valentin
2017-11-22 16:04                                       ` Sudeep Holla
2017-11-22  1:25                                 ` Viresh Kumar
2017-11-22 11:08                                   ` Viresh Kumar
2017-11-21 17:03                             ` Lukasz Luba
2017-11-21 17:09                       ` Eduardo Valentin
2017-11-21 17:49                         ` Daniel Lezcano
2017-11-16  2:47         ` Viresh Kumar
2017-11-17  7:55           ` Daniel Lezcano
2017-11-15 11:31   ` Javi Merino
2017-11-15 11:39     ` Daniel Lezcano
2017-11-15 15:09       ` Eduardo Valentin [this message]
2017-11-15 18:08 ` [PATCH 0/4] cpu_cooling: cooling dev registration cleanups Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171115150924.GA1758@localhost.localdomain \
    --to=edubezval@gmail.com \
    --cc=amit.kachhap@gmail.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=javi.merino@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=mingo@redhat.com \
    --cc=punit.agrawal@arm.com \
    --cc=rjw@rjwysocki.net \
    --cc=rostedt@goodmis.org \
    --cc=rui.zhang@intel.com \
    --cc=vincent.guittot@linaro.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).