From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javi Merino Subject: Re: [PATCH 4/4] cpu_cooling: Drop static-power related stuff Date: Tue, 21 Nov 2017 18:00:07 +0000 Message-ID: <20171121180006.GA26638@localhost> References: <65fef2a1-d23f-3de2-bd91-021296c3e2f7@arm.com> <20171116152058.GR3257@vireshk-i7> <2810372.fJ2vMN0cWO@aspire.rjw.lan> <20171116234422.GA6141@localhost.localdomain> <878tf5tbfj.fsf@e105922-lin.cambridge.arm.com> <35d3751d-f28d-38c2-02b2-c9980f11c52e@arm.com> <5A144CB3.50806@gmail.com> <20171121165703.GA2499@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Received: from mail-wr0-f196.google.com ([209.85.128.196]:43865 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751290AbdKUSAf (ORCPT ); Tue, 21 Nov 2017 13:00:35 -0500 Content-Disposition: inline In-Reply-To: <20171121165703.GA2499@localhost.localdomain> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Eduardo Valentin Cc: Vincent Guittot , Lukasz Luba , Daniel Lezcano , Ionela Voinescu , Punit Agrawal , "Rafael J. Wysocki" , Viresh Kumar , "Rafael J. Wysocki" , Amit Daniel Kachhap , Zhang Rui , Steven Rostedt , Ingo Molnar , Linux PM , Lukasz Luba , Linux Kernel Mailing List Hi, On Tue, Nov 21, 2017 at 08:57:06AM -0800, Eduardo Valentin wrote: [snip] > As I said before, the minimal you guys (ARM and Linaro) can do is to at > least upstream the Juno code! as a reference. Come on guys? what is > preventing you to upstream Juno model? As Ionela pointed out earlier in the thread, the cpufreq driver for Juno was not acceptable for mainline because it used platform specific code. When it was converted to cpufreq-dt, the static power was left behind because it can't be represented in device tree. This is because there isn't a function that works for every SoC, different process nodes (among other things) will need different functions. So it can't be just a bunch of coefficients in DT, we need a function. Hence the callback. In a nutshell, mainline does not want platform specific code, but we haven't figured out how to calculate static power without platform specific code. Cheers, Javi