public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Javi Merino <javi.merino@kernel.org>
Cc: Eduardo Valentin <edubezval@gmail.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Lukasz Luba <llu.ker.dev@gmail.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Ionela Voinescu <ionela.voinescu@arm.com>,
	Punit Agrawal <punit.agrawal@arm.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Amit Daniel Kachhap <amit.kachhap@gmail.com>,
	Zhang Rui <rui.zhang@intel.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ingo Molnar <mingo@redhat.com>,
	Linux PM <linux-pm@vger.kernel.org>,
	Lukasz Luba <lukasz.luba@arm.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] cpu_cooling: Drop static-power related stuff
Date: Wed, 22 Nov 2017 06:55:32 +0530	[thread overview]
Message-ID: <20171122012532.GG6125@vireshk-i7> (raw)
In-Reply-To: <20171121180006.GA26638@localhost>

On 21-11-17, 18:00, Javi Merino wrote:
> As Ionela pointed out earlier in the thread, the cpufreq driver for Juno
> was not acceptable for mainline because it used platform specific code.

Can we get a link to that thread? I don't remember what I have commented earlier
but the above doesn't seem to be entirely true.

The basic idea is to use as much common stuff as possible and so to use
cpufreq-dt.c if possible. Its not that we are against platform specific bits,
they are fine if they are really required.

> When it was converted to cpufreq-dt, the static power was left behind
> because it can't be represented in device tree.  This is because there
> isn't a function that works for every SoC, different process nodes
> (among other things) will need different functions.  So it can't be just
> a bunch of coefficients in DT, we need a function.  Hence the callback.

Sure thing. And we can make this happen if we need. We aren't blocking it.

> In a nutshell, mainline does not want platform specific code, but we

Not really. We don't want platform specific code in arch/arm64, but we can have
that in drivers/opp/ for example if required.

Please start a discussion (in a separate thread if you want) and we can get
cpufreq support updated for Juno very easily.

And don't worry about this patch here. We can surely drop the patch if someone
is serious enough to start using it. But there needs to be a commitment, nothing
more.

-- 
viresh

  parent reply	other threads:[~2017-11-22  1:25 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-15  9:19 [PATCH 0/4] cpu_cooling: cooling dev registration cleanups Viresh Kumar
2017-11-15  9:19 ` [PATCH 1/4] cpu_cooling: Make of_cpufreq_power_cooling_register() parse DT Viresh Kumar
2017-11-15  9:19 ` [PATCH 2/4] cpu_cooling: Remove unused cpufreq_power_cooling_register() Viresh Kumar
2017-11-15  9:19 ` [PATCH 3/4] cpu_cooling: Keep only one of_cpufreq*cooling_register() helper Viresh Kumar
2017-11-15  9:19 ` [PATCH 4/4] cpu_cooling: Drop static-power related stuff Viresh Kumar
2017-11-15 10:18   ` Daniel Lezcano
2017-11-15 11:25     ` Viresh Kumar
2017-11-15 15:43     ` Eduardo Valentin
2017-11-15 18:17       ` Rafael J. Wysocki
2017-11-15 18:20         ` Eduardo Valentin
2017-11-16 15:02           ` Ionela Voinescu
2017-11-16 15:20             ` Viresh Kumar
2017-11-16 23:31               ` Rafael J. Wysocki
2017-11-16 23:44                 ` Eduardo Valentin
2017-11-17 11:02                   ` Punit Agrawal
2017-11-17 11:06                     ` Viresh Kumar
2017-11-21 11:30                     ` Ionela Voinescu
2017-11-21 13:06                       ` Daniel Lezcano
2017-11-21 15:56                         ` Lukasz Luba
2017-11-21 16:08                           ` Vincent Guittot
2017-11-21 16:57                             ` Eduardo Valentin
2017-11-21 18:00                               ` Javi Merino
2017-11-21 18:05                                 ` Daniel Lezcano
2017-11-21 18:13                                   ` Eduardo Valentin
2017-11-21 23:32                                     ` Lukasz Luba
2017-11-21 18:12                                 ` Eduardo Valentin
2017-11-22 10:59                                   ` Sudeep Holla
2017-11-22 11:10                                     ` Viresh Kumar
2017-11-22 11:17                                       ` Sudeep Holla
2017-11-22 15:38                                       ` Eduardo Valentin
2017-11-22 15:34                                     ` Eduardo Valentin
2017-11-22 16:04                                       ` Sudeep Holla
2017-11-22  1:25                                 ` Viresh Kumar [this message]
2017-11-22 11:08                                   ` Viresh Kumar
2017-11-21 17:03                             ` Lukasz Luba
2017-11-21 17:09                       ` Eduardo Valentin
2017-11-21 17:49                         ` Daniel Lezcano
2017-11-16  2:47         ` Viresh Kumar
2017-11-17  7:55           ` Daniel Lezcano
2017-11-15 11:31   ` Javi Merino
2017-11-15 11:39     ` Daniel Lezcano
2017-11-15 15:09       ` Eduardo Valentin
2017-11-15 18:08 ` [PATCH 0/4] cpu_cooling: cooling dev registration cleanups Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171122012532.GG6125@vireshk-i7 \
    --to=viresh.kumar@linaro.org \
    --cc=amit.kachhap@gmail.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=edubezval@gmail.com \
    --cc=ionela.voinescu@arm.com \
    --cc=javi.merino@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=llu.ker.dev@gmail.com \
    --cc=lukasz.luba@arm.com \
    --cc=mingo@redhat.com \
    --cc=punit.agrawal@arm.com \
    --cc=rafael@kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=rostedt@goodmis.org \
    --cc=rui.zhang@intel.com \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox