From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eduardo Valentin Subject: Re: [PATCH] of: thermal: Introduce "hwmon" optional property Date: Mon, 4 Dec 2017 17:46:17 -0800 Message-ID: <20171205014615.GA3536@localhost.localdomain> References: <20170710115146.27313-1-kukabu@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-yb0-f196.google.com ([209.85.213.196]:38098 "EHLO mail-yb0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751582AbdLEBqW (ORCPT ); Mon, 4 Dec 2017 20:46:22 -0500 Received: by mail-yb0-f196.google.com with SMTP id v12so7466274ybj.5 for ; Mon, 04 Dec 2017 17:46:22 -0800 (PST) Content-Disposition: inline In-Reply-To: Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Michael Tatarinov Cc: linux-pm@vger.kernel.org, Zhang Rui On Wed, Jul 12, 2017 at 11:49:10AM +0400, Michael Tatarinov wrote: > Hello > > Some clarifications for this patch. > I uses CONFIG_THERMAL_HWMON feature on Raspberry PI. It works ok with > the downstream thermal driver because it uses > thermal_zone_device_register(). After I switches to the upstream > driver this feature doesn't work because it uses > thermal_zone_of_sensor_register(). > I would like to use this opportunity and in the future. I would be OK with the linux,no-hwmon flag, but that needs to be acked by the DT folks. > > 2017-07-10 15:51 GMT+04:00, Michael Tatarinov : > > Introduce an optional property called, hwmon, which enable > > registration in hwmon subsystems. > > > > Cc: Zhang Rui > > Cc: Eduardo Valentin > > Signed-off-by: Michael Tatarinov > > --- > > Documentation/devicetree/bindings/thermal/thermal.txt | 6 ++++++ > > drivers/thermal/of-thermal.c | 3 +-- > > 2 files changed, 7 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt > > b/Documentation/devicetree/bindings/thermal/thermal.txt > > index 88b6ea1ad290..4e51fbd4efa2 100644 > > --- a/Documentation/devicetree/bindings/thermal/thermal.txt > > +++ b/Documentation/devicetree/bindings/thermal/thermal.txt > > @@ -175,6 +175,10 @@ Optional property: > > 2000mW, while on a 10'' tablet is around > > 4500mW. > > > > +- hwmon: Register the thermal zone in hwmon subsystems > > + Type: boolean (requires CONFIG_THERMAL_HWMON). > > + Size: one cell > > + > > Note: The delay properties are bound to the maximum dT/dt (temperature > > derivative over time) in two situations for a thermal zone: > > (i) - when passive cooling is activated (polling-delay-passive); and > > @@ -556,6 +560,8 @@ thermal-zones { > > > > sustainable-power = <2500>; > > > > + hwmon; > > + > > trips { > > /* Trips are based on resulting linear equation */ > > cpu_trip: cpu-trip { > > diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c > > index d04ec3b9e5ff..ce580a57313b 100644 > > --- a/drivers/thermal/of-thermal.c > > +++ b/drivers/thermal/of-thermal.c > > @@ -994,8 +994,7 @@ int __init of_parse_thermal_zones(void) > > goto exit_free; > > } > > > > - /* No hwmon because there might be hwmon drivers registering */ > > - tzp->no_hwmon = true; > > + tzp->no_hwmon = !of_property_read_bool(child, "hwmon"); > > > > if (!of_property_read_u32(child, "sustainable-power", &prop)) > > tzp->sustainable_power = prop; > > -- > > 2.9.4 > > > >