Re: [PATCH v3 02/11] thermal: armada: Use msleep for long delays

Gregory CLEMENT
2017-12-14T10:51:47Z

Hi Miquel,

On jeu., déc. 14 2017, Miquel Raynal <miquel.raynal@free-electrons.com> wrote:

> From: Baruch Siach <baruch@tkos.co.il>
>
> Use msleep for long (> 10ms) delays, instead of the busy waiting mdelay.
> All delays are called from the probe routine, where scheduling is
> allowed.
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> Signed-off-by: Miquel Raynal <miquel.raynal@free-electrons.com>

Reviewed-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

Thanks,

Gregory
> ---
> drivers/thermal/armada_thermal.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c
> index 706d74798cbe..6c4af2622d4f 100644
> --- a/drivers/thermal/armada_thermal.c
> +++ b/drivers/thermal/armada_thermal.c
> @@ -113,7 +113,7 @@ static void armada370_init_sensor(struct platform_device *pdev,
> reg &= ~PMU_TDC0_START_CAL_MASK;
> writel(reg, priv->control);
>
> - mdelay(10);
> + msleep(10);
> }
>
> static void armada375_init_sensor(struct platform_device *pdev,
> @@ -127,11 +127,11 @@ static void armada375_init_sensor(struct platform_device *pdev,
> reg &= ~A375_HW_RESETn;
>
> writel(reg, priv->control + 4);
> - mdelay(20);
> + msleep(20);
>
> reg |= A375_HW_RESETn;
> writel(reg, priv->control + 4);
> - mdelay(50);
> + msleep(50);
> }
>
> static void armada380_init_sensor(struct platform_device *pdev,
> @@ -143,7 +143,7 @@ static void armada380_init_sensor(struct platform_device *pdev,
> if (!(reg & A380_HW_RESET)) {
> reg |= A380_HW_RESET;
> writel(reg, priv->control);
> - mdelay(10);
> + msleep(10);
> }
> }
>
> --
> 2.11.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.