From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Chunyan Zhang <chunyan.zhang@spreadtrum.com>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Vincent Wang <vincent.wang@spreadtrum.com>,
Orson Zhai <orson.zhai@spreadtrum.com>,
Chunyan Zhang <zhang.lyra@gmail.com>
Subject: Re: [PATCH] PM / OPP: list_del_rcu should be used in function _remove_list_dev
Date: Mon, 18 Dec 2017 10:07:47 +0100 [thread overview]
Message-ID: <20171218090747.GB10436@kroah.com> (raw)
In-Reply-To: <20171218083223.26647-1-chunyan.zhang@spreadtrum.com>
On Mon, Dec 18, 2017 at 04:32:23PM +0800, Chunyan Zhang wrote:
> From: Vincent Wang <vincent.wang@spreadtrum.com>
>
> list_del_rcu() should be used to replace list_del() in the function
> _remove_list_dev(), since the opp is a rcu protected pointer.
>
> For example, on an ARM big.Little platform of spreadtrum, there are
> little cluster, big cluster and gpu using pm_opp. And the opp_table
> of big cluster will be removed when big cluster is removed, which
> is implemented in the cpufreq driver. Sometimes an issue maybe occur:
>
> [ 237.647758] c0 Unable to handle kernel paging request at virtual address dead000000000110
> [ 237.647776] c0 pgd = ffffffc073e78000
> [ 237.647786] c0 [dead000000000110] *pgd=0000000000000000, *pud=0000000000000000
> [ 237.647808] c0 Internal error: Oops: 96000004 [#1] PREEMPT SMP
> [ 237.653535] c0 Modules linked in: sprdwl_ng(O) mtty marlin2_fm mali_kbase(O)
> [ 237.653569] c0 CPU: 0 PID: 38 Comm: kworker/u12:1 Tainted: G S W O 4.4.83+ #1
> [ 237.653578] c0 Hardware name: Spreadtrum SP9850KHsmt 1h10 Board (DT)
> [ 237.653594] c0 Workqueue: devfreq_wq devfreq_monitor
> [ 237.653605] c0 task: ffffffc0babd0d80 task.stack: ffffffc0badbc000
> [ 237.653619] c0 PC is at _find_device_opp+0x58/0xac
> [ 237.653629] c0 LR is at dev_pm_opp_find_freq_ceil+0x2c/0xb8
>
> [ 237.921294] c0 Call trace:
> [ 237.921425] c0 [<ffffff80085362b0>] _find_device_opp+0x58/0xac
> [ 237.921437] c0 [<ffffff8008536560>] dev_pm_opp_find_freq_ceil+0x2c/0xb8
> [ 237.921452] c0 [<ffffff80088760f4>] devfreq_recommended_opp+0x54/0x7c
> [ 237.921494] c0 [<ffffff8000b6a96c>] kbase_wait_write_flush+0x164/0x358 [mali_kbase]
> [ 237.921504] c0 [<ffffff800887485c>] update_devfreq+0x8c/0xf8
> [ 237.921514] c0 [<ffffff80088749e4>] devfreq_monitor+0x34/0x94
> [ 237.921529] c0 [<ffffff80080bd75c>] process_one_work+0x154/0x458
> [ 237.921539] c0 [<ffffff80080be428>] worker_thread+0x134/0x4a4
> [ 237.921551] c0 [<ffffff80080c4bec>] kthread+0xdc/0xf0
> [ 237.921564] c0 [<ffffff8008085f20>] ret_from_fork+0x10/0x30
>
> Cc: stable <stable@vger.kernel.org> # 4.4
> Signed-off-by: Vincent Wang <vincent.wang@spreadtrum.com>
> Signed-off-by: Chunyan Zhang <chunyan.zhang@spreadtrum.com>
> ---
>
> This patch is only for 4.4 stable branch.
> Once this patch accepted, I can cook a similar patch for 4.9 stable branch.
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
next prev parent reply other threads:[~2017-12-18 9:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 8:32 [PATCH] PM / OPP: list_del_rcu should be used in function _remove_list_dev Chunyan Zhang
2017-12-18 8:43 ` Viresh Kumar
2017-12-18 9:07 ` Greg Kroah-Hartman [this message]
2017-12-18 9:11 ` Viresh Kumar
2017-12-18 9:32 ` Greg Kroah-Hartman
2017-12-18 9:37 ` Chunyan Zhang
2017-12-18 9:40 ` Viresh Kumar
-- strict thread matches above, loose matches on Subject: below --
2017-12-18 9:37 Chunyan Zhang
2017-12-18 9:57 ` Greg Kroah-Hartman
2018-01-15 8:03 ` Greg Kroah-Hartman
2018-01-15 8:33 ` Chunyan Zhang
2017-12-18 8:31 Chunyan Zhang
2017-12-18 9:07 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171218090747.GB10436@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=chunyan.zhang@spreadtrum.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=orson.zhai@spreadtrum.com \
--cc=vincent.wang@spreadtrum.com \
--cc=viresh.kumar@linaro.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).