From: Viresh Kumar <viresh.kumar@linaro.org>
To: Joel Fernandes <joelaf@google.com>
Cc: Patrick Bellasi <patrick.bellasi@arm.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Linux PM <linux-pm@vger.kernel.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Morten Rasmussen <morten.rasmussen@arm.com>,
Juri Lelli <juri.lelli@redhat.com>, Todd Kjos <tkjos@android.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] sched: cpufreq: Keep track of cpufreq utilization update flags
Date: Tue, 19 Dec 2017 08:52:17 +0530 [thread overview]
Message-ID: <20171219032217.GN19815@vireshk-i7> (raw)
In-Reply-To: <CAJWu+ooGRedM_w6xBwhb+ype0SMmM8w-uEjjpzaTWmp-GueZDg@mail.gmail.com>
On 18-12-17, 19:18, Joel Fernandes wrote:
> Hi Viresh,
>
> On Mon, Dec 18, 2017 at 7:12 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > On 18-12-17, 12:14, Patrick Bellasi wrote:
> >> For example, swithing from:
> >>
> >> - void (*func)(struct update_util_data *data, u64 time,
> >> - unsigned int flags))
> >> + void (*func)(struct update_util_data *data, u64 time,
> >> + unsigned int flags, bool set))
> >>
> >> Where the additional boolean is actually used to define which
> >> operation we wanna perform on the flags?
> >
> > The code will eventually have the same complexity or ugliness in both
> > the cases. I would like to start with another flag for now and see if
> > people prefer another parameter.
>
> Though I think that will solve Rafael's concern of polluting the flags
> for something schedutil specific. I also feel adding extra callback
> parameter is cleaner than 2 new clear flags.
Okay, I will then wait for Rafael to come online and comment on what
he would prefer before posting.
--
viresh
next prev parent reply other threads:[~2017-12-19 3:22 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-13 9:53 [PATCH 0/4] sched: cpufreq: Track util update flags Viresh Kumar
2017-12-13 9:53 ` [PATCH 1/4] cpufreq: schedutil: Initialize sg_cpu->flags to 0 Viresh Kumar
2017-12-13 11:13 ` Juri Lelli
2017-12-13 11:22 ` Viresh Kumar
2017-12-13 9:53 ` [PATCH 2/4] sched: cpufreq: Keep track of cpufreq utilization update flags Viresh Kumar
2017-12-13 11:26 ` Juri Lelli
2017-12-13 11:29 ` Viresh Kumar
2017-12-16 16:40 ` Rafael J. Wysocki
2017-12-16 16:47 ` Viresh Kumar
2017-12-17 0:19 ` Rafael J. Wysocki
2017-12-18 4:59 ` Viresh Kumar
2017-12-18 11:35 ` Rafael J. Wysocki
2017-12-18 11:59 ` Viresh Kumar
2017-12-18 12:14 ` Patrick Bellasi
2017-12-19 3:12 ` Viresh Kumar
2017-12-19 3:18 ` Joel Fernandes
2017-12-19 3:22 ` Viresh Kumar [this message]
2017-12-19 3:26 ` Viresh Kumar
2017-12-19 3:30 ` Joel Fernandes
2017-12-19 3:41 ` Viresh Kumar
2017-12-19 10:44 ` Rafael J. Wysocki
2017-12-18 17:34 ` Rafael J. Wysocki
2017-12-19 19:25 ` Peter Zijlstra
2017-12-20 4:04 ` Viresh Kumar
2017-12-20 8:31 ` Peter Zijlstra
2017-12-20 8:48 ` Viresh Kumar
2017-12-20 9:17 ` Peter Zijlstra
2017-12-20 12:55 ` Patrick Bellasi
2017-12-20 13:28 ` Peter Zijlstra
2017-12-20 14:31 ` Patrick Bellasi
2017-12-20 14:52 ` Rafael J. Wysocki
2017-12-20 15:01 ` Patrick Bellasi
2017-12-20 14:47 ` Rafael J. Wysocki
2017-12-20 14:51 ` Peter Zijlstra
2017-12-20 17:27 ` Juri Lelli
2017-12-20 18:17 ` Peter Zijlstra
2017-12-13 9:53 ` [PATCH 3/4] cpufreq: schedutil: Don't pass flags to sugov_set_iowait_boost() Viresh Kumar
2017-12-13 11:28 ` Juri Lelli
2017-12-13 9:53 ` [PATCH 4/4] cpufreq: schedutil: Don't call sugov_get_util() unnecessarily Viresh Kumar
2017-12-13 11:34 ` Juri Lelli
2017-12-13 12:02 ` Viresh Kumar
2017-12-19 3:26 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171219032217.GN19815@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=dietmar.eggemann@arm.com \
--cc=joelaf@google.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=patrick.bellasi@arm.com \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tkjos@android.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox