From: kbuild test robot <lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Adam Thomson
<Adam.Thomson.Opensource-WBD+wuPFNBhBDgjK7y7TUQ@public.gmane.org>
Cc: kbuild-all-JC7UmRfGjtg@public.gmane.org,
Heikki Krogerus
<heikki.krogerus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Yueyao Zhu <yueyao.zhu-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Rui Miguel Silva <rmfrfs-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
support.opensource-WBD+wuPFNBhBDgjK7y7TUQ@public.gmane.org
Subject: Re: [PATCH v3 1/7] typec: tcpm: Add PD Rev 3.0 definitions to PD header
Date: Wed, 20 Dec 2017 21:48:41 +0800 [thread overview]
Message-ID: <201712202155.YqKCGBhX%fengguang.wu@intel.com> (raw)
In-Reply-To: <014fd84202a31c37d09c92fd30482d09457432f7.1513599506.git.Adam.Thomson.Opensource-WBD+wuPFNBhBDgjK7y7TUQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 6364 bytes --]
Hi Adam,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on next-20171214]
[also build test ERROR on v4.15-rc4]
[cannot apply to usb/usb-testing hwmon/hwmon-next v4.15-rc3 v4.15-rc2 v4.15-rc1]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Adam-Thomson/typec-tcpm-Add-sink-side-support-for-PPS/20171220-205656
config: i386-randconfig-x016-201751 (attached as .config)
compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
Note: the linux-review/Adam-Thomson/typec-tcpm-Add-sink-side-support-for-PPS/20171220-205656 HEAD 79d2ed6a04117216910ac1dad566e86599a0bcf5 builds fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>):
drivers/usb/typec/tcpm.c: In function 'tcpm_pd_send_source_caps':
>> drivers/usb/typec/tcpm.c:794:27: error: macro "PD_HEADER_LE" requires 6 arguments, but only 5 given
port->message_id, 0);
^
>> drivers/usb/typec/tcpm.c:791:16: error: 'PD_HEADER_LE' undeclared (first use in this function)
msg.header = PD_HEADER_LE(PD_CTRL_REJECT,
^~~~~~~~~~~~
drivers/usb/typec/tcpm.c:791:16: note: each undeclared identifier is reported only once for each function it appears in
drivers/usb/typec/tcpm.c:800:24: error: macro "PD_HEADER_LE" requires 6 arguments, but only 5 given
port->nr_src_pdo);
^
drivers/usb/typec/tcpm.c: In function 'tcpm_pd_send_sink_caps':
drivers/usb/typec/tcpm.c:819:27: error: macro "PD_HEADER_LE" requires 6 arguments, but only 5 given
port->message_id, 0);
^
drivers/usb/typec/tcpm.c:816:16: error: 'PD_HEADER_LE' undeclared (first use in this function)
msg.header = PD_HEADER_LE(PD_CTRL_REJECT,
^~~~~~~~~~~~
drivers/usb/typec/tcpm.c:825:24: error: macro "PD_HEADER_LE" requires 6 arguments, but only 5 given
port->nr_snk_pdo);
^
drivers/usb/typec/tcpm.c: In function 'vdm_run_state_machine':
drivers/usb/typec/tcpm.c:1190:41: error: macro "PD_HEADER_LE" requires 6 arguments, but only 5 given
port->message_id, port->vdo_count);
^
drivers/usb/typec/tcpm.c:1187:16: error: 'PD_HEADER_LE' undeclared (first use in this function)
msg.header = PD_HEADER_LE(PD_DATA_VENDOR_DEF,
^~~~~~~~~~~~
drivers/usb/typec/tcpm.c: In function 'tcpm_pd_send_control':
drivers/usb/typec/tcpm.c:1669:26: error: macro "PD_HEADER_LE" requires 6 arguments, but only 5 given
port->message_id, 0);
^
drivers/usb/typec/tcpm.c:1667:15: error: 'PD_HEADER_LE' undeclared (first use in this function)
msg.header = PD_HEADER_LE(type, port->pwr_role,
^~~~~~~~~~~~
drivers/usb/typec/tcpm.c: In function 'tcpm_pd_send_request':
drivers/usb/typec/tcpm.c:1946:26: error: macro "PD_HEADER_LE" requires 6 arguments, but only 5 given
port->message_id, 1);
^
drivers/usb/typec/tcpm.c:1943:15: error: 'PD_HEADER_LE' undeclared (first use in this function)
msg.header = PD_HEADER_LE(PD_DATA_REQUEST,
^~~~~~~~~~~~
vim +/PD_HEADER_LE +794 drivers/usb/typec/tcpm.c
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 782
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 783 static int tcpm_pd_send_source_caps(struct tcpm_port *port)
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 784 {
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 785 struct pd_message msg;
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 786 int i;
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 787
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 788 memset(&msg, 0, sizeof(msg));
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 789 if (!port->nr_src_pdo) {
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 790 /* No source capabilities defined, sink only */
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 @791 msg.header = PD_HEADER_LE(PD_CTRL_REJECT,
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 792 port->pwr_role,
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 793 port->data_role,
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 @794 port->message_id, 0);
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 795 } else {
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 796 msg.header = PD_HEADER_LE(PD_DATA_SOURCE_CAP,
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 797 port->pwr_role,
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 798 port->data_role,
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 799 port->message_id,
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 800 port->nr_src_pdo);
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 801 }
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 802 for (i = 0; i < port->nr_src_pdo; i++)
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 803 msg.payload[i] = cpu_to_le32(port->src_pdo[i]);
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 804
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 805 return tcpm_pd_transmit(port, TCPC_TX_SOP, &msg);
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 806 }
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 807
:::::: The code at line 794 was first introduced by commit
:::::: f0690a25a140b853b1842fa80faf828601bb47e8 staging: typec: USB Type-C Port Manager (tcpm)
:::::: TO: Guenter Roeck <groeck-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
:::::: CC: Greg Kroah-Hartman <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29861 bytes --]
next prev parent reply other threads:[~2017-12-20 13:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 12:41 [PATCH v3 0/7] typec: tcpm: Add sink side support for PPS Adam Thomson
2017-12-18 12:41 ` [PATCH v3 1/7] typec: tcpm: Add PD Rev 3.0 definitions to PD header Adam Thomson
[not found] ` <014fd84202a31c37d09c92fd30482d09457432f7.1513599506.git.Adam.Thomson.Opensource-WBD+wuPFNBhBDgjK7y7TUQ@public.gmane.org>
2017-12-20 13:48 ` kbuild test robot [this message]
2017-12-18 12:41 ` [PATCH v3 2/7] typec: tcpm: Add ADO header for Alert message handling Adam Thomson
2017-12-18 12:41 ` [PATCH v3 3/7] typec: tcpm: Add SDB header for Status " Adam Thomson
2017-12-18 12:41 ` [PATCH v3 4/7] typec: tcpm: Add core support for sink side PPS Adam Thomson
2017-12-18 12:41 ` [PATCH v3 5/7] power: supply: Add 'connected_type' property and supporting code Adam Thomson
2017-12-18 12:41 ` [PATCH v3 6/7] typec: tcpm: Represent source supply through power_supply class Adam Thomson
2017-12-20 15:24 ` [PATCH] typec: tcpm: fix ptr_ret.cocci warnings kbuild test robot
[not found] ` <4a578dd161acf70aa33cc887493d2854547c0a2b.1513599506.git.Adam.Thomson.Opensource-WBD+wuPFNBhBDgjK7y7TUQ@public.gmane.org>
2017-12-20 15:24 ` [PATCH v3 6/7] typec: tcpm: Represent source supply through power_supply class kbuild test robot
2017-12-18 12:41 ` [PATCH v3 7/7] typec: tcpm: Add support for sink PPS related messages Adam Thomson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201712202155.YqKCGBhX%fengguang.wu@intel.com \
--to=lkp-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=Adam.Thomson.Opensource-WBD+wuPFNBhBDgjK7y7TUQ@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=heikki.krogerus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=kbuild-all-JC7UmRfGjtg@public.gmane.org \
--cc=linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rmfrfs-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=support.opensource-WBD+wuPFNBhBDgjK7y7TUQ@public.gmane.org \
--cc=yueyao.zhu-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox