From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eduardo Valentin Subject: Re: [PATCH 0/2] thermal, OPP: move the CPU power estimation to the OPP library Date: Fri, 12 Jan 2018 09:47:21 -0800 Message-ID: <20180112174720.GB11076@localhost.localdomain> References: <20180109110252.13557-1-quentin.perret@arm.com> <20180110193431.GE3837@localhost.localdomain> <20180111094257.GA6603@e108498-lin.cambridge.arm.com> <20180112172410.GA10243@localhost.localdomain> <20180112174410.GA28012@e108498-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pg0-f67.google.com ([74.125.83.67]:35901 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964844AbeALRrW (ORCPT ); Fri, 12 Jan 2018 12:47:22 -0500 Received: by mail-pg0-f67.google.com with SMTP id j2so5021985pgv.3 for ; Fri, 12 Jan 2018 09:47:22 -0800 (PST) Content-Disposition: inline In-Reply-To: <20180112174410.GA28012@e108498-lin.cambridge.arm.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Quentin Perret Cc: linux-pm@vger.kernel.org, rjw@rjwysocki.net, vireshk@kernel.org, nm@ti.com, sboyd@codeaurora.org, sudeep.holla@arm.com, amit.kachhap@gmail.com, javi.merino@kernel.org, rui.zhang@intel.com, matthias.bgg@gmail.com, dietmar.eggemann@arm.com, morten.rasmussen@arm.com, patrick.bellasi@arm.com, ionela.voinescu@arm.com On Fri, Jan 12, 2018 at 05:44:10PM +0000, Quentin Perret wrote: > On Friday 12 Jan 2018 at 09:24:12 (-0800), Eduardo Valentin wrote: > > I would rather see a single series showing all users of the new API > > instead. If you want to split the series and add a link to the users > > of the new API into the series that takes it out of thermal subsystem, > > I am also fine, as long as I see the other users. Otherwise, this is a > > light nack, reason: no real new users of the new API, even though I > > can surely see how the scheduler could use it. But if you do not really > > present the code of the new users, this is just speculation. > > > > Presenting the entire code of the new API + all its users can help us to > > judge if: (1) a new API is really needed, (2) where it should be place. > > > > Understood. I will still send a v2 next week with the changes requested > by Viresh and I'll mark my upcoming scheduler patches as depending on this > series. Please note on this series the patches that will be depending on this too, so this present review can also benefit. > > Cheers, > Quentin