Linux Power Management development
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Eduardo Valentin <edubezval@gmail.com>
Cc: Zhang Rui <rui.zhang@intel.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3] thermal: Add cooling device's statistics in sysfs
Date: Tue, 16 Jan 2018 15:30:42 +0530	[thread overview]
Message-ID: <20180116100042.GJ22978@vireshk-i7> (raw)
In-Reply-To: <20180115163221.GA3756@localhost.localdomain>

On 15-01-18, 08:32, Eduardo Valentin wrote:
> Same set you added for cooling devices should also be reflected on
> thermal zones, but instead of cooling state, you want to do the account
> on trips, at least for the context of this patch set.

I never dived deep into the thermal core earlier and never had to implement any
SoC side of it as well, so consider me a newbie here :)

I tried to look into the core on what I can do to get some stats out for the
zones, but I am a bit confused.

handle_thermal_trip() looked to be the function where I could update stats but
then I realized that this is artificially called for every possible trip in most
of the cases from thermal_zone_device_update() and so this can't be the real
place.

Does it mean that this needs to be updated somehow from the thermal governor's,
->throttle() callback? I am not sure if doing it from every governor code is
what we want to do. And then the trip point of cooling devices can be different
within the same thermal zone.

And so I posted the first patch again without thermal zone stuff in it as that
would take more time.

-- 
viresh

      parent reply	other threads:[~2018-01-16 10:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-11  9:36 [PATCH V3] thermal: Add cooling device's statistics in sysfs Viresh Kumar
2018-01-12 11:09 ` Aishwarya Pant
2018-01-12 17:25   ` Eduardo Valentin
2018-01-12 17:46 ` Eduardo Valentin
2018-01-15  4:46   ` Viresh Kumar
2018-01-15 16:32     ` Eduardo Valentin
2018-01-16  8:44       ` Viresh Kumar
2018-01-16 10:00       ` Viresh Kumar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180116100042.GJ22978@vireshk-i7 \
    --to=viresh.kumar@linaro.org \
    --cc=edubezval@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox