Re: [PATCH v3 0/2] thermal, OPP: move the CPU power estimation to the OPP library

[Viresh Kumar <viresh.kumar@linaro.org>]

On 19-01-18, 09:45, Quentin Perret wrote:
> Hi,
> 
> Currently, IPA estimates the power dissipated by a CPU at each available OPP
> using its capacitance (the dynamic-power-coefficient DT binding). This series
> relocates this per-OPP power model in the OPP core as a preparation for
> future changes. More specifically:
> 
>    1. The current DT-based approach for power estimation will need deep
>       changes to support SCMI-provided power values. While the thermal
>       subsystem is not necessarily the best place to hide multiple power
>       estimation methods, the OPP library appears to be a good candidate to
>       implement the required platform abstraction and respect the existing
>       design (the thermal subsystem already relies on the OPP library to
>       provide voltages no matter where they come from -- DT or SCPI).
> 
>    2. The energy models of CPUs will be needed by other clients in the future
>       (such as the task scheduler or CPUFreq governors for example) in order
>       to make energy-aware decisions. The relocation to the OPP library will
>       enable code re-use and all clients will benefit form the platform
>       abstraction mentioned previously.
> 
> As mentionned during the review of V1, this series will have a chance to get
> merged only when the clients (the scheduler, or the SCMI driver) depending
> on it are ready to be merged as well. This V3 is here for reference and
> addresses the main changes requested on the previous versions.
> 
> Changes in v2:
>  - Changed the OPP power estimation to be done upon OPP creation (V. Kumar)
>  - Updated the cover letter to motivate the choice of PM OPP (E. Valentin)
> 
> Changes in v3
>  - Removed the has_power logic to simplify the thermal code (V. Kumar)
>  - Moved _opp_estimate_power() call to _opp_add() to avoid duplication (V. Kumar)

So I am mostly fine with the changes here and can apply them to the OPP tree as
soon as Eduardo Acks them (as he had some concerns about the users).

Thanks.

-- 
viresh