From: Viresh Kumar <viresh.kumar@linaro.org>
To: Joel Fernandes <joelaf@google.com>
Cc: Quentin Perret <quentin.perret@arm.com>,
Linux PM <linux-pm@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
vireshk@kernel.org, nm@ti.com, sboyd@codeaurora.org,
sudeep.holla@arm.com, Amit Kachhap <amit.kachhap@gmail.com>,
javi.merino@kernel.org, rui.zhang@intel.com,
Eduardo Valentin <edubezval@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Morten Rasmussen <morten.rasmussen@arm.com>,
Patrick Bellasi <patrick.bellasi@arm.com>,
Ionela Voinescu <ionela.voinescu@arm.com>,
Todd Kjos <tkjos@google.com>
Subject: Re: [PATCH v3 2/2] thermal: cpu_cooling: use power models from the OPP library
Date: Tue, 23 Jan 2018 08:17:57 +0530 [thread overview]
Message-ID: <20180123024757.GB13020@vireshk-i7> (raw)
In-Reply-To: <CAJWu+oqdS9LUqaKMWpS5gG-HAD5UGL8SW2ZxED55BR6Pvmbu=A@mail.gmail.com>
On 22-01-18, 13:30, Joel Fernandes wrote:
> I think I wasn't articulating well enough what I meant but sorry if I
> missed something...
>
> In the current code, if capacitance is not available, then
> update_freq_table -> dev_pm_opp_find_freq_ceil isn't called. However
> in the new code, with this patch, you're calling update_freq_table
> anyway and later discovering through the new 'found_power' variable
> that capacitance isn't possibly available. It seems the new code will
> be slower than the older one.
>
> Instead of doing that, if you queried that capacitance isn't available
> in advance, then you could avoid finding that out later. Admittedly, I
> am new to these code paths so forgive me if I'm noisy, just trying to
> help. And thanks for explaining anything I missed.
No, you are correct. But this is init code and executes only once per cooling
device and so speed isn't a big issue for us right now. We may eventually have a
helper like that, just that we wanted to add it only after more than one user
needs it.
--
viresh
next prev parent reply other threads:[~2018-01-23 2:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-19 9:45 [PATCH v3 0/2] thermal, OPP: move the CPU power estimation to the OPP library Quentin Perret
2018-01-19 9:45 ` [PATCH v3 1/2] PM / OPP: introduce an OPP power estimation helper Quentin Perret
2018-01-19 23:36 ` Joel Fernandes
2018-01-22 5:12 ` Viresh Kumar
2018-01-22 10:00 ` Quentin Perret
2018-01-20 4:10 ` Joel Fernandes
2018-01-22 9:56 ` Quentin Perret
2018-01-22 21:33 ` Joel Fernandes
2018-01-19 9:45 ` [PATCH v3 2/2] thermal: cpu_cooling: use power models from the OPP library Quentin Perret
2018-01-19 23:15 ` Joel Fernandes
2018-01-22 5:11 ` Viresh Kumar
2018-01-22 21:30 ` Joel Fernandes
2018-01-23 2:47 ` Viresh Kumar [this message]
2018-01-22 11:03 ` Quentin Perret
2018-01-19 10:12 ` [PATCH v3 0/2] thermal, OPP: move the CPU power estimation to " Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180123024757.GB13020@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=amit.kachhap@gmail.com \
--cc=dietmar.eggemann@arm.com \
--cc=edubezval@gmail.com \
--cc=ionela.voinescu@arm.com \
--cc=javi.merino@kernel.org \
--cc=joelaf@google.com \
--cc=linux-pm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=morten.rasmussen@arm.com \
--cc=nm@ti.com \
--cc=patrick.bellasi@arm.com \
--cc=quentin.perret@arm.com \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=sboyd@codeaurora.org \
--cc=sudeep.holla@arm.com \
--cc=tkjos@google.com \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox