From: Viresh Kumar <viresh.kumar@linaro.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Bo Yan <byan@nvidia.com>,
sgurrappadi@nvidia.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq: skip cpufreq resume if it's not suspended
Date: Mon, 5 Feb 2018 14:53:05 +0530 [thread overview]
Message-ID: <20180205092305.GF28462@vireshk-i7> (raw)
In-Reply-To: <1563547.VDOW1Ixonm@aspire.rjw.lan>
On 05-02-18, 10:19, Rafael J. Wysocki wrote:
> On Tuesday, January 23, 2018 10:57:55 PM CET Bo Yan wrote:
> > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> > index 41d148af7748..95b1c4afe14e 100644
> > --- a/drivers/cpufreq/cpufreq.c
> > +++ b/drivers/cpufreq/cpufreq.c
> > @@ -1680,6 +1680,10 @@ void cpufreq_resume(void)
> > if (!cpufreq_driver)
> > return;
> >
> > + if (unlikely(!cpufreq_suspended)) {
> > + pr_warn("%s: resume after failing suspend\n", __func__);
> > + return;
> > + }
> > cpufreq_suspended = false;
> >
> > if (!has_target() && !cpufreq_driver->resume)
>
> I've just edited this patch somewhat (mostly by dropping the pr_warn())
> and queued it up.
You can add my Ack as well.
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
prev parent reply other threads:[~2018-02-05 9:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 21:57 [PATCH] cpufreq: skip cpufreq resume if it's not suspended Bo Yan
2018-01-24 2:02 ` Rafael J. Wysocki
2018-01-24 20:53 ` Bo Yan
2018-02-02 11:54 ` Rafael J. Wysocki
2018-02-02 19:34 ` Saravana Kannan
2018-02-02 21:28 ` Bo Yan
2018-02-05 4:01 ` Viresh Kumar
2018-02-05 8:50 ` Rafael J. Wysocki
2018-02-05 9:05 ` Viresh Kumar
2018-02-15 21:27 ` Saravana Kannan
2018-02-15 22:06 ` Rafael J. Wysocki
2018-01-25 19:15 ` [PATCH v2] " Bo Yan
2018-02-05 9:19 ` [PATCH] " Rafael J. Wysocki
2018-02-05 9:23 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180205092305.GF28462@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=byan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sgurrappadi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox