From: Viresh Kumar <viresh.kumar@linaro.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: edubezval@gmail.com, kevin.wangtao@linaro.org,
leo.yan@linaro.org, vincent.guittot@linaro.org,
amit.kachhap@gmail.com, linux-kernel@vger.kernel.org,
Zhang Rui <rui.zhang@intel.com>,
Javi Merino <javi.merino@kernel.org>,
"open list:THERMAL" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH 5/8] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver
Date: Fri, 9 Feb 2018 15:11:00 +0530 [thread overview]
Message-ID: <20180209094100.GM28462@vireshk-i7> (raw)
In-Reply-To: <54759b82-29e9-f376-bbe8-dcf683ed0cce@linaro.org>
On 07-02-18, 11:34, Daniel Lezcano wrote:
> On 07/02/2018 10:12, Viresh Kumar wrote:
> > What about cpuidle_cooling_unregister() ?
>
> The unregister function is not needed because cpuidle can't be unloaded.
> The cpuidle cooling device is registered after the cpuidle successfully
> initialized itself, there is no error path.
Okay, then there are two more things here.
First, you don't need a kref in your patch and simple counter should
be used instead, as kref is obviously more heavy to be used for the
single error path here.
Secondly, what about CPU hotplug ? For example, the cpu-freq cooling
device gets removed currently if all CPUs of a cluster are
hotplugged-out. But with your code, even if the CPUs are gone, their
cpu-idle cooling device will stay.
--
viresh
next prev parent reply other threads:[~2018-02-09 9:41 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1516721671-16360-1-git-send-email-daniel.lezcano@linaro.org>
2018-01-23 15:34 ` [PATCH 1/8] thermal/drivers/cpu_cooling: Fixup the header and copyright Daniel Lezcano
2018-01-31 5:17 ` Viresh Kumar
2018-01-31 7:03 ` Daniel Lezcano
2018-01-23 15:34 ` [PATCH 2/8] thermal/drivers/cpu_cooling: Add Software Package Data Exchange (SPDX) Daniel Lezcano
2018-01-31 5:18 ` Viresh Kumar
2018-02-08 14:05 ` Philippe Ombredanne
2018-02-08 14:07 ` Daniel Lezcano
2018-01-23 15:34 ` [PATCH 3/8] thermal/drivers/cpu_cooling: Remove pointless field Daniel Lezcano
2018-01-31 5:20 ` Viresh Kumar
2018-01-23 15:34 ` [PATCH 4/8] thermal/drivers/Kconfig: Convert the CPU cooling device to a choice Daniel Lezcano
2018-01-24 16:34 ` Daniel Thompson
2018-01-24 16:59 ` Daniel Lezcano
2018-01-25 10:57 ` Daniel Thompson
2018-01-25 13:36 ` Daniel Lezcano
2018-01-26 12:16 ` Daniel Thompson
2018-01-26 13:25 ` Daniel Lezcano
2018-01-31 10:09 ` Daniel Thompson
2018-02-07 9:04 ` Viresh Kumar
2018-02-07 10:15 ` Daniel Lezcano
2018-02-07 10:20 ` Viresh Kumar
2018-01-23 15:34 ` [PATCH 5/8] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver Daniel Lezcano
2018-01-31 9:01 ` Vincent Guittot
2018-01-31 9:33 ` Daniel Lezcano
2018-01-31 9:46 ` Vincent Guittot
2018-01-31 9:50 ` Daniel Lezcano
2018-01-31 9:56 ` Vincent Guittot
2018-01-31 15:27 ` Daniel Lezcano
2018-02-01 7:57 ` Vincent Guittot
2018-02-01 8:25 ` Daniel Lezcano
2018-02-05 13:54 ` Daniel Thompson
2018-02-06 11:34 ` Daniel Lezcano
2018-02-07 9:12 ` Viresh Kumar
2018-02-07 10:34 ` Daniel Lezcano
2018-02-07 10:41 ` Viresh Kumar
2018-02-09 9:41 ` Viresh Kumar [this message]
2018-02-16 17:39 ` Daniel Lezcano
2018-01-23 15:34 ` [PATCH 7/8] cpuidle/drivers/cpuidle-arm: Register the cooling device Daniel Lezcano
2018-01-23 15:34 ` [PATCH 8/8] thermal/drivers/cpu_cooling: Add the combo cpu " Daniel Lezcano
2018-02-02 10:42 ` Viresh Kumar
2018-02-02 14:30 ` Daniel Lezcano
2018-02-05 4:17 ` Viresh Kumar
2018-02-05 10:32 ` Daniel Lezcano
2018-02-06 4:28 ` Viresh Kumar
2018-02-06 10:48 ` Daniel Lezcano
2018-02-07 7:26 ` Viresh Kumar
2018-02-07 10:05 ` Daniel Lezcano
2018-02-09 9:44 ` Viresh Kumar
2018-02-16 9:11 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180209094100.GM28462@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=amit.kachhap@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=javi.merino@kernel.org \
--cc=kevin.wangtao@linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox