From mboxrd@z Thu Jan 1 00:00:00 1970 From: Henrique de Moraes Holschuh Subject: Re: [PATCH v13 4/4] battery: Add the ThinkPad "Not Charging" quirk Date: Fri, 9 Feb 2018 08:45:30 -0200 Message-ID: <20180209104530.s5i6lymcpgkqyego@khazad-dum.debian.net> References: <20180207145936.ockmmkipxtwkdsot@thinkpad> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180207145936.ockmmkipxtwkdsot@thinkpad> Sender: platform-driver-x86-owner@vger.kernel.org To: Ognjen Galic Cc: Andy Shevchenko , "Rafael J. Wysocki" , "Rafael J. Wysocki" , Len Brown , Robert Moore , Lv Zheng , ACPI Devel Maling List , devel@acpica.org, Darren Hart , Andy Shevchenko , Henrique de Moraes Holschuh , Sebastian Reichel , Platform Driver , ibm-acpi-devel@lists.sourceforge.net, Linux PM , Christoph =?iso-8859-1?Q?B=F6hmwalder?= , Kevin Locke List-Id: linux-pm@vger.kernel.org On Wed, 07 Feb 2018, Ognjen Galic wrote: > The EC/ACPI firmware on Lenovo ThinkPads used to report a status > of "Unknown" when the battery is between the charge start and > charge stop thresholds. On Windows, it reports "Not Charging" > so the quirk has been added to also report correctly. > > Now the "status" attribute returns "Not Charging" when the > battery on ThinkPads is not physicaly charging. > > Reviewed-by: Andy Shevchenko > Signed-off-by: Ognjen Galic AFAIK, This behavior goes back to the initial SBS implementation in the IBM era ECs of the Thinkpads... We've always called it "idle" in the linux-thinkpad community. The behavior comes from SBS (http://smartbattery.org/specs/), the EC was reporting its status (charging/not charging *THIS* battery) in one bit, and the battery's status (discharging/not discharging *THIS* battery) in a different bit. It was rather simple to observe the behavior of those bits in a two-battery system. Would that apply to these newer Lenovo models? If so, you might want to consider using "idle", instead. "not charging" does _not_ imply "neither charging nor discharging", while "idle" does. -- Henrique Holschuh