From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viresh Kumar Subject: Re: [PATCH 2/2] cpufreq: scmi: add thermal dependency Date: Wed, 14 Mar 2018 10:40:04 +0530 Message-ID: <20180314051004.GF15832@vireshk-i7> References: <20180313114607.2061209-1-arnd@arndb.de> <20180313114607.2061209-2-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180313114607.2061209-2-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann Cc: "Rafael J. Wysocki" , Sudeep Holla , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-pm@vger.kernel.org On 13-03-18, 12:45, Arnd Bergmann wrote: > A built-in scmi cpufreq driver cannot link against a modular > thermal framework: > > drivers/cpufreq/scmi-cpufreq.o: In function `scmi_cpufreq_ready': > scmi-cpufreq.c:(.text+0x40): undefined reference to `of_cpufreq_cooling_register' > drivers/cpufreq/scmi-cpufreq.o: In function `scmi_cpufreq_exit': > scmi-cpufreq.c:(.text+0x88): undefined reference to `cpufreq_cooling_unregister' > > This adds a Kconfig dependency that makes sure this configuration > is not possible, while allowing all configurations that can work. > Note that disabling CPU_THERMAL means we don't care about the > THERMAL dependency. > > Signed-off-by: Arnd Bergmann > --- > drivers/cpufreq/Kconfig.arm | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm > index d9457d1e535c..7f56fe5183f2 100644 > --- a/drivers/cpufreq/Kconfig.arm > +++ b/drivers/cpufreq/Kconfig.arm > @@ -242,6 +242,7 @@ config ARM_SA1110_CPUFREQ > config ARM_SCMI_CPUFREQ > tristate "SCMI based CPUfreq driver" > depends on ARM_SCMI_PROTOCOL || COMPILE_TEST > + depends on !CPU_THERMAL || THERMAL > select PM_OPP > help > This adds the CPUfreq driver support for ARM platforms using SCMI Acked-by: Viresh Kumar -- viresh