From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viresh Kumar Subject: Re: [PATCH] cpufreq: armada-37xx: Fix clock leak Date: Thu, 5 Apr 2018 10:21:53 +0530 Message-ID: <20180405045153.GL3572@vireshk-i7> References: <20180404144444.4142-1-gregory.clement@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180404144444.4142-1-gregory.clement@bootlin.com> Sender: stable-owner@vger.kernel.org To: Gregory CLEMENT Cc: "Rafael J. Wysocki" , linux-pm@vger.kernel.org, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Thomas Petazzoni , linux-arm-kernel@lists.infradead.org, Antoine Tenart , =?iso-8859-1?Q?Miqu=E8l?= Raynal , Maxime Chevallier , Nadav Haklai , Victor Gu , Marcin Wojtas , Wilson Ding , Hua Jing , Neta Zur Hershkovits , stable@vger.kernel.org List-Id: linux-pm@vger.kernel.org On 04-04-18, 16:44, Gregory CLEMENT wrote: > There was no clk_put() balancing the clk_get(). This commit fixes it. > > Fixes: 92ce45fb875d ("cpufreq: Add DVFS support for Armada 37xx") > Cc: > Reported-by: Thomas Petazzoni > Signed-off-by: Gregory CLEMENT > --- > drivers/cpufreq/armada-37xx-cpufreq.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/cpufreq/armada-37xx-cpufreq.c b/drivers/cpufreq/armada-37xx-cpufreq.c > index c6ebc88a7d8d..72a2975499db 100644 > --- a/drivers/cpufreq/armada-37xx-cpufreq.c > +++ b/drivers/cpufreq/armada-37xx-cpufreq.c > @@ -202,6 +202,7 @@ static int __init armada37xx_cpufreq_driver_init(void) > cur_frequency = clk_get_rate(clk); > if (!cur_frequency) { > dev_err(cpu_dev, "Failed to get clock rate for CPU\n"); > + clk_put(clk); > return -EINVAL; > } > > @@ -210,6 +211,7 @@ static int __init armada37xx_cpufreq_driver_init(void) > return -EINVAL; > > armada37xx_cpufreq_dvfs_setup(nb_pm_base, clk, dvfs->divider); > + clk_put(clk); > > for (load_lvl = ARMADA_37XX_DVFS_LOAD_0; load_lvl < LOAD_LEVEL_NR; > load_lvl++) { Acked-by: Viresh Kumar -- viresh